Re: [Mesa-dev] [PATCH 0.5/5] i965/gen9/fast-clear: Handle linear???SRGB conversion

2015-12-01 Thread Pohjolainen, Topi
On Wed, Nov 25, 2015 at 06:23:01PM +0100, Neil Roberts wrote: > If GL_FRAMEBUFFER_SRGB is enabled when writing to an SRGB-capable > framebuffer then the color will be converted from linear to SRGB > before being written. There is no chance for the hardware to do this > itself because it can't

Re: [Mesa-dev] [PATCH 0.5/5] i965/gen9/fast-clear: Handle linear???SRGB conversion

2015-12-01 Thread Neil Roberts
"Pohjolainen, Topi" writes: >> + /* Handle linear→SRGB conversion */ >> + if (brw->ctx.Color.sRGBEnabled && >> + _mesa_get_srgb_format_linear(mt->format) != mt->format) { > > Patch five disables fast clear for single-sampled if > brw->ctx.Color.sRGBEnabled

Re: [Mesa-dev] [PATCH 0.5/5] i965/gen9/fast-clear: Handle linear???SRGB conversion

2015-12-01 Thread Pohjolainen, Topi
On Tue, Dec 01, 2015 at 05:27:19PM +, Neil Roberts wrote: > "Pohjolainen, Topi" writes: > > >> + /* Handle linear???SRGB conversion */ > >> + if (brw->ctx.Color.sRGBEnabled && > >> + _mesa_get_srgb_format_linear(mt->format) != mt->format) { > > > > Patch

[Mesa-dev] [PATCH 0.5/5] i965/gen9/fast-clear: Handle linear→SRGB conversion

2015-11-25 Thread Neil Roberts
If GL_FRAMEBUFFER_SRGB is enabled when writing to an SRGB-capable framebuffer then the color will be converted from linear to SRGB before being written. There is no chance for the hardware to do this itself because it can't modify the clear color that is programmed in the surface state so it seems