On 21.11.2014 23:57, Samuel Iglesias Gonsálvez wrote:
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a trimmed set of piglit tests (related to
format conversion), ~5700 tests selected with the
On 25/11/14 09:59, Michel Dänzer wrote:
On 21.11.2014 23:57, Samuel Iglesias Gonsálvez wrote:
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a trimmed set of piglit tests
(related to
format
On 25/11/14 09:43, Samuel Iglesias Gonsálvez wrote:
On 25/11/14 09:59, Michel Dänzer wrote:
On 21.11.2014 23:57, Samuel Iglesias Gonsálvez wrote:
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a trimmed set of piglit tests (related
to
format conversion), ~5700 tests selected with the following filter:
-t format -t color -t tex -t image
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a trimmed set of piglit tests (related to
format conversion), ~5700 tests selected with the following filter:
-t format -t color -t tex -t image -t swizzle -t clamp -t rgb -t lum -t pix
-t fbo -t frame
Any
On Tue, 2014-11-18 at 13:41 -0800, Jason Ekstrand wrote:
Iago,
Most of this looks pretty good to me. The one primary concern I have
is in the handling of integer formats. I made the comment in a couple
of patches, but I'll make it in general here. In a lot of the code,
when you convert
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a trimmed set of piglit tests (related
to
format conversion), ~5700 tests selected with the following filter:
-t format -t color -t tex -t image
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 19/11/14 09:25, Iago Toral wrote:
On Tue, 2014-11-18 at 13:41 -0800, Jason Ekstrand wrote:
Iago,
Most of this looks pretty good to me. The one primary concern I have
is in the handling of integer formats. I made the comment in a couple
of
On 19/11/14 08:29, Iago Toral wrote:
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a trimmed set of piglit tests (related to
format conversion), ~5700 tests selected with the following filter:
-t
On Wed, 2014-11-19 at 01:15 +, Emil Velikov wrote:
Hi Iago,
On 18/11/14 08:43, Iago Toral Quiroga wrote:
[snip]
Summary of the patches:
* Patches 1-7 are general fixes to the current code that were found while
working on this.
Have you noticed if any of those fixes resolves a
This is the fist of two series of patches to address:
https://bugs.freedesktop.org/show_bug.cgi?id=84566
The idea is that we have a lot of format conversion code scattered through
different files in the repository, a lot of that is redundant / duplicated,
so this intends to address that issue.
I forgot to say that the series is available for testing here:
https://github.com/Igalia/mesa/tree/itoral-autogen-packing-review
Also, one of the patches was held for review by the list owner due to
its size (patch 12, which handles auto-generation of format_unpack.c),
so reviewers can fetch it
The idea is that we have a lot of format conversion code scattered
through
different files in the repository, a lot of that is redundant /
duplicated,
so this intends to address that issue.
First, I think this is a great goal. And while I haven't reviewed them
in detail, just from
Jose,
I haven't had time to fully review Iago and Samuel's code, so I can't 100%
comment on it right now. However, let me make a few comments on the
overarching plan as it were.
On Tue, Nov 18, 2014 at 2:36 AM, Jose Fonseca jfons...@vmware.com wrote:
The idea is that we have a lot of format
Iago,
Most of this looks pretty good to me. The one primary concern I have is in
the handling of integer formats. I made the comment in a couple of
patches, but I'll make it in general here. In a lot of the code, when you
convert from integer formats to float, you treat them as if they are
On 18/11/14 17:10, Jason Ekstrand wrote:
Jose,
I haven't had time to fully review Iago and Samuel's code, so I can't
100% comment on it right now. However, let me make a few comments on
the overarching plan as it were.
On Tue, Nov 18, 2014 at 2:36 AM, Jose Fonseca jfons...@vmware.com
On Tue, Nov 18, 2014 at 1:42 PM, Jose Fonseca jfons...@vmware.com wrote:
On 18/11/14 17:10, Jason Ekstrand wrote:
Jose,
I haven't had time to fully review Iago and Samuel's code, so I can't
100% comment on it right now. However, let me make a few comments on
the overarching plan as it
Hi Iago,
On 18/11/14 08:43, Iago Toral Quiroga wrote:
[snip]
Summary of the patches:
* Patches 1-7 are general fixes to the current code that were found while
working on this.
Have you noticed if any of those fixes resolves a piglit and/or a real
world application ? If so it might be worth
18 matches
Mail list logo
