Re: [Mesa-dev] [PATCH 01/20] nir: Add intrinsics from ARB_shader_group_vote

2017-07-18 Thread Connor Abbott
With Ken's suggestion, this is Reviewed-by: Connor Abbott On Thu, Jul 6, 2017 at 4:48 PM, Matt Turner wrote: > These are intrinsics rather than opcodes, because they operate across > channels. > --- > src/compiler/glsl/glsl_to_nir.cpp | 22

Re: [Mesa-dev] [PATCH 01/20] nir: Add intrinsics from ARB_shader_group_vote

2017-07-17 Thread Kenneth Graunke
On Thursday, July 6, 2017 4:48:11 PM PDT Matt Turner wrote: > These are intrinsics rather than opcodes, because they operate across > channels. > --- > src/compiler/glsl/glsl_to_nir.cpp | 22 ++ > src/compiler/nir/nir_intrinsics.h | 5 + > 2 files changed, 27

Re: [Mesa-dev] [PATCH 01/20] nir: Add intrinsics from ARB_shader_group_vote

2017-07-17 Thread Matt Turner
I've force pushed this series with all suggested changes to the ballot branch of my tree git://people.freedesktop.org/~mattst88/mesa ballot The only two reviews I have so far are my own, after changing the authorship on two patches to Curro. With the branchpoint coming up this week, I'd

Re: [Mesa-dev] [PATCH 01/20] nir: Add intrinsics from ARB_shader_group_vote

2017-07-06 Thread Matt Turner
On Thu, Jul 6, 2017 at 5:07 PM, Connor Abbott wrote: > FYI, I already have another series which adds ARB_shader_ballot and > ARB_shader_group_vote intrinsics, in addition to adding some more > precise semantics to represent the restrictions on ballotARB() and > similar things

Re: [Mesa-dev] [PATCH 01/20] nir: Add intrinsics from ARB_shader_group_vote

2017-07-06 Thread Connor Abbott
FYI, I already have another series which adds ARB_shader_ballot and ARB_shader_group_vote intrinsics, in addition to adding some more precise semantics to represent the restrictions on ballotARB() and similar things [0]. The problem is that marking ballot as can_eliminate but not can_reorder is

[Mesa-dev] [PATCH 01/20] nir: Add intrinsics from ARB_shader_group_vote

2017-07-06 Thread Matt Turner
These are intrinsics rather than opcodes, because they operate across channels. --- src/compiler/glsl/glsl_to_nir.cpp | 22 ++ src/compiler/nir/nir_intrinsics.h | 5 + 2 files changed, 27 insertions(+) diff --git a/src/compiler/glsl/glsl_to_nir.cpp