Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-21 Thread Iago Toral
On Fri, 2014-11-21 at 17:40 +0900, Michel Dänzer wrote: > On 21.11.2014 17:07, Iago Toral wrote: > > On Thu, 2014-11-20 at 11:10 -0800, Jason Ekstrand wrote: > >> On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral wrote: > >> Just out of curiosity: is there any gain in avoiding the GL > >>

Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-21 Thread Michel Dänzer
On 21.11.2014 17:07, Iago Toral wrote: On Thu, 2014-11-20 at 11:10 -0800, Jason Ekstrand wrote: On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral wrote: Just out of curiosity: is there any gain in avoiding the GL types in the conversion code? As I said in my reply to Jose

Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-21 Thread Iago Toral
On Thu, 2014-11-20 at 11:10 -0800, Jason Ekstrand wrote: > > > On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral wrote: > On Wed, 2014-11-19 at 11:28 -0800, Jason Ekstrand wrote: > > By and large, this looks good to me. Most of my comments > are cosmetic > > or suggest

Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-20 Thread Jason Ekstrand
On Thu, Nov 20, 2014 at 1:48 AM, Iago Toral wrote: > On Wed, 2014-11-19 at 11:28 -0800, Jason Ekstrand wrote: > > By and large, this looks good to me. Most of my comments are cosmetic > > or suggestions for added documentation. There is one issue that I > > think is subtly wrong with integer fo

Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-20 Thread Iago Toral
On Wed, 2014-11-19 at 11:28 -0800, Jason Ekstrand wrote: > By and large, this looks good to me. Most of my comments are cosmetic > or suggestions for added documentation. There is one issue that I > think is subtly wrong with integer format conversion but that should > be easy to fix. > > --Jaso

Re: [Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-19 Thread Jason Ekstrand
By and large, this looks good to me. Most of my comments are cosmetic or suggestions for added documentation. There is one issue that I think is subtly wrong with integer format conversion but that should be easy to fix. --Jason On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga wrote: > From

[Mesa-dev] [PATCH 01/29] mesa: Add an implementation of a master convert function.

2014-11-18 Thread Iago Toral Quiroga
From: Jason Ekstrand v2 by Iago Toral : - When testing if we can directly pack we should use the src format to check if we are packing from an RGBA format. The original code used the dst format for the ubyte case by mistake. - Fixed incorrect number of bits for dst, it was computed using the