Re: [Mesa-dev] [PATCH 02/29] mesa: Set normalized=true for float array formats.

2014-11-21 Thread Jason Ekstrand
On Thu, Nov 20, 2014 at 11:33 PM, Iago Toral wrote: > On Thu, 2014-11-20 at 10:40 -0800, Jason Ekstrand wrote: > > > > > > On Wed, Nov 19, 2014 at 11:24 PM, Iago Toral > > wrote: > > Hi Jason, > > > > we discussed this some weeks ago actually, the detailed > > explanation

Re: [Mesa-dev] [PATCH 02/29] mesa: Set normalized=true for float array formats.

2014-11-20 Thread Iago Toral
On Thu, 2014-11-20 at 10:40 -0800, Jason Ekstrand wrote: > > > On Wed, Nov 19, 2014 at 11:24 PM, Iago Toral > wrote: > Hi Jason, > > we discussed this some weeks ago actually, the detailed > explanation is > here: > https://bugs.freedesktop.org/sh

Re: [Mesa-dev] [PATCH 02/29] mesa: Set normalized=true for float array formats.

2014-11-20 Thread Jason Ekstrand
On Wed, Nov 19, 2014 at 11:24 PM, Iago Toral wrote: > Hi Jason, > > we discussed this some weeks ago actually, the detailed explanation is > here: > https://bugs.freedesktop.org/show_bug.cgi?id=84566#c5 > > the short answer is that this is necessary because there is a normalized > parameter to _m

Re: [Mesa-dev] [PATCH 02/29] mesa: Set normalized=true for float array formats.

2014-11-19 Thread Iago Toral
Hi Jason, we discussed this some weeks ago actually, the detailed explanation is here: https://bugs.freedesktop.org/show_bug.cgi?id=84566#c5 the short answer is that this is necessary because there is a normalized parameter to _mesa_swizzle_and_convert, and when we deal with float types we want t

Re: [Mesa-dev] [PATCH 02/29] mesa: Set normalized=true for float array formats.

2014-11-19 Thread Jason Ekstrand
I'm not sure what I think about this. Does it make a functional change other than consistancy? --Jason On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga wrote: > In order to check if a format is normalized Mesa does something like this: > normalized = !_mesa_is_enum_format_integer(srcFormat);

[Mesa-dev] [PATCH 02/29] mesa: Set normalized=true for float array formats.

2014-11-18 Thread Iago Toral Quiroga
In order to check if a format is normalized Mesa does something like this: normalized = !_mesa_is_enum_format_integer(srcFormat); So all float types will set normalized to true. Since our mesa_array_format includes a normalized flag for each type we want to make it consistent with this. --- src/m