Re: [Mesa-dev] [PATCH 03/10] mesa: add fbo/texture support for ARB_texture_cube_map_array

2012-11-07 Thread Kenneth Graunke
On 11/06/2012 02:15 PM, Dave Airlie wrote: This adds the mesa core + texture + fbo support for the texture cube map array extension. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/fbobject.c | 9 - src/mesa/main/mtypes.h | 2 ++ src/mesa/main/shared.c | 1 +

[Mesa-dev] [PATCH 03/10] mesa: add fbo/texture support for ARB_texture_cube_map_array

2012-11-06 Thread Dave Airlie
This adds the mesa core + texture + fbo support for the texture cube map array extension. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/main/fbobject.c | 9 - src/mesa/main/mtypes.h | 2 ++ src/mesa/main/shared.c | 1 + src/mesa/main/teximage.c | 85

Re: [Mesa-dev] [PATCH 03/10] mesa: add fbo/texture support for ARB_texture_cube_map_array

2012-11-06 Thread Brian Paul
On 11/06/2012 03:15 PM, Dave Airlie wrote: This adds the mesa core + texture + fbo support for the texture cube map array extension. Signed-off-by: Dave Airlieairl...@redhat.com --- src/mesa/main/fbobject.c | 9 - src/mesa/main/mtypes.h | 2 ++ src/mesa/main/shared.c | 1 +

Re: [Mesa-dev] [PATCH 03/10] mesa: add fbo/texture support for ARB_texture_cube_map_array

2012-11-06 Thread Dave Airlie
+ + /* +* Use the proxy texture driver hook to see if the size/level/etc are +* legal. +*/ That comment seems to be in the wrong place. The code after it is concerned with format/type checking. must be a bit of cut-n-paste will clean it up. I think you missed updating

Re: [Mesa-dev] [PATCH 03/10] mesa: add fbo/texture support for ARB_texture_cube_map_array

2012-11-06 Thread Brian Paul
On 11/06/2012 04:45 PM, Dave Airlie wrote: + + /* +* Use the proxy texture driver hook to see if the size/level/etc are +* legal. +*/ That comment seems to be in the wrong place. The code after it is concerned with format/type checking. must be a bit of cut-n-paste will clean