Re: [Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

2014-03-08 Thread Kenneth Graunke
On 02/05/2014 04:30 PM, Ian Romanick wrote: On 02/05/2014 01:07 PM, Fabian Bieler wrote: The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ constant takes care of this automatically. Signed-off-by:

Re: [Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

2014-03-08 Thread Fabian Bieler
On Sat, Mar 8, 2014, at 11:13 AM, Kenneth Graunke wrote: On 02/05/2014 04:30 PM, Ian Romanick wrote: On 02/05/2014 01:07 PM, Fabian Bieler wrote: The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The

Re: [Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

2014-03-08 Thread Kenneth Graunke
On 03/08/2014 04:24 AM, Fabian Bieler wrote: On Sat, Mar 8, 2014, at 11:13 AM, Kenneth Graunke wrote: On 02/05/2014 04:30 PM, Ian Romanick wrote: On 02/05/2014 01:07 PM, Fabian Bieler wrote: The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further

[Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

2014-02-19 Thread Fabian Bieler
The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ constant takes care of this automatically. v2: Don't set source-string-number to line number. Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm

[Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

2014-02-13 Thread Fabian Bieler
The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ constant takes care of this automatically. v2: Don't set source-string-number to line number. Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm

[Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

2014-02-05 Thread Fabian Bieler
The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ constant takes care of this automatically. Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/gsraytrace.cpp | 10 +++--- 1 file

Re: [Mesa-dev] [PATCH 03/12] glsl/gsraytrace: Use __LINE__ macro to set line numbers in GLSL source strings.

2014-02-05 Thread Ian Romanick
On 02/05/2014 01:07 PM, Fabian Bieler wrote: The hardcoded numbers are a few lines off at the moment. Keeping track of the numbers through further modifications is inconvenient. The __LINE__ constant takes care of this automatically. Signed-off-by: Fabian Bieler fabianbie...@fastmail.fm ---