Re: [Mesa-dev] [PATCH 03/12] nir: Add a loop analysis pass

I made a bunch more comments but they're all cosmetic. The one non-cosmetic thing I'd like to see changed before we merge is that we fix the case where the break is in the else. Feel free to grab the tip of my jenkins_vulkan branch and squash it in if you like the approach I took. Or you can do

[Mesa-dev] [PATCH 03/12] nir: Add a loop analysis pass

From: Thomas Helland This pass detects induction variables and calculates the trip count of loops to be used for loop unrolling. I've removed support for float induction values for now, for the simple reason that they don't appear in my shader-db collection, and so I

Re: [Mesa-dev] [PATCH 03/12] nir: Add a loop analysis pass

On Sat, 2016-08-27 at 14:08 +0200, Thomas Helland wrote: > 2016-08-27 8:03 GMT+02:00 Timothy Arceri m>: > > > > This pass detects induction variables and calculates the > > trip count of loops to be used for loop unrolling. > > > > I've removed support for float

Re: [Mesa-dev] [PATCH 03/12] nir: Add a loop analysis pass

2016-08-27 8:03 GMT+02:00 Timothy Arceri : > This pass detects induction variables and calculates the > trip count of loops to be used for loop unrolling. > > I've removed support for float induction values for now, for the > simple reason that they don't appear in my

[Mesa-dev] [PATCH 03/12] nir: Add a loop analysis pass

This pass detects induction variables and calculates the trip count of loops to be used for loop unrolling. I've removed support for float induction values for now, for the simple reason that they don't appear in my shader-db collection, and so I don't see it as common enough that we want to