Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-12 Thread Jan Vesely
On Tue, 2016-07-12 at 21:19 +0200, Vedran Miletić wrote: > 09.07.2016 u 00:10, Jan Vesely je napisao/la: > > we still get 'macro redefined' complains from the compiler. and if > > anyone adds ifdef DEBUG code in the future it will cause unexpected > > behaviour. > > this goes for every file that in

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-12 Thread Vedran Miletić
09.07.2016 u 00:10, Jan Vesely je napisao/la: we still get 'macro redefined' complains from the compiler. and if anyone adds ifdef DEBUG code in the future it will cause unexpected behaviour. this goes for every file that includes llvm headers. it'd be nicer to get mesa (and llvm) to stop using g

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-08 Thread Jan Vesely
On Fri, 2016-07-08 at 14:39 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: > > > This gets rid of most ifdef's from the invocation.cpp code -- > > > Only a > > > couple of them are left which will be removed differently in the >

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-08 Thread Francisco Jerez
Jan Vesely writes: > On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: >> This gets rid of most ifdef's from the invocation.cpp code -- Only a >> couple of them are left which will be removed differently in the >> following commits. >> >> Reviewed-by: Serge Martin >> --- >>  src/gallium

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-08 Thread Jan Vesely
On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: > This gets rid of most ifdef's from the invocation.cpp code -- Only a > couple of them are left which will be removed differently in the > following commits. > > Reviewed-by: Serge Martin > --- >  src/gallium/state_trackers/clover/Makefil

[Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-03 Thread Francisco Jerez
This gets rid of most ifdef's from the invocation.cpp code -- Only a couple of them are left which will be removed differently in the following commits. Reviewed-by: Serge Martin --- src/gallium/state_trackers/clover/Makefile.sources | 1 + src/gallium/state_trackers/clover/llvm/compat.hpp |