Re: [Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-09-08 Thread Ian Romanick
On 08/28/2016 06:17 PM, Ilia Mirkin wrote: > On Sun, Aug 28, 2016 at 9:05 PM, Ian Romanick wrote: >> On 08/28/2016 08:56 AM, Ilia Mirkin wrote: >>> FWIW this fails for GL_DOT3_RGBA_EXT but works for GL_DOT3_RGB_EXT >>> [according to glean's texCombine test]. (I suspect the

Re: [Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-08-28 Thread Ilia Mirkin
On Sun, Aug 28, 2016 at 9:05 PM, Ian Romanick wrote: > On 08/28/2016 08:56 AM, Ilia Mirkin wrote: >> FWIW this fails for GL_DOT3_RGBA_EXT but works for GL_DOT3_RGB_EXT >> [according to glean's texCombine test]. (I suspect the existing > > Looking at the test results... any

Re: [Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-08-28 Thread Ian Romanick
On 08/28/2016 08:56 AM, Ilia Mirkin wrote: > FWIW this fails for GL_DOT3_RGBA_EXT but works for GL_DOT3_RGB_EXT > [according to glean's texCombine test]. (I suspect the existing Looking at the test results... any idea what it's actually doing? Ignoring alpha and using 1.0? Using garbage? Other?

Re: [Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-08-28 Thread Ilia Mirkin
FWIW this fails for GL_DOT3_RGBA_EXT but works for GL_DOT3_RGB_EXT [according to glean's texCombine test]. (I suspect the existing GL_DOT3_RGBA/RGB had a similar behavior.) I'm testing in a slightly unsupported environment - the NV25 graph class running on a NV34 (GeForce FX 5200), but I think

Re: [Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-08-24 Thread Ilia Mirkin
On Wed, Aug 24, 2016 at 2:46 PM, Ian Romanick wrote: > From: Ian Romanick > > GL_DOT3_RGB_EXT and GL_DOT3_RGBA_EXT. are nearly identical to > GL_DOT3_RGB and GL_DOT3_RGBA. The only difference is the _EXT > versions do not apply the post-scale.

[Mesa-dev] [PATCH 05/13] nouveau: Enable EXT_texture_env_dot3 on NV10 and NV20

2016-08-24 Thread Ian Romanick
From: Ian Romanick GL_DOT3_RGB_EXT and GL_DOT3_RGBA_EXT. are nearly identical to GL_DOT3_RGB and GL_DOT3_RGBA. The only difference is the _EXT versions do not apply the post-scale. Just smash logscale to 0 so that RC_OUT_SCALE_1 is always used. NOTE: I have not