Re: [Mesa-dev] [PATCH 05/15] ac: revert new LLVM 7.0 behavior for fdiv

2018-10-29 Thread Marek Olšák
Fixed in master. Marek On Mon, Oct 29, 2018 at 6:50 AM Connor Abbott wrote: > ctx->f32_1 probably needs to be replaced by the appropriately-sized > float, like LLVMConstReal(1., ...) > On Mon, Oct 29, 2018 at 11:45 AM Timothy Arceri > wrote: > > > > Hi Marek, > > > > It's late and I haven't du

Re: [Mesa-dev] [PATCH 05/15] ac: revert new LLVM 7.0 behavior for fdiv

2018-10-29 Thread Connor Abbott
ctx->f32_1 probably needs to be replaced by the appropriately-sized float, like LLVMConstReal(1., ...) On Mon, Oct 29, 2018 at 11:45 AM Timothy Arceri wrote: > > Hi Marek, > > It's late and I haven't dug into this any further but this patch causes > a whole bunch of f64 piglit tests to fail for th

Re: [Mesa-dev] [PATCH 05/15] ac: revert new LLVM 7.0 behavior for fdiv

2018-10-29 Thread Timothy Arceri
Hi Marek, It's late and I haven't dug into this any further but this patch causes a whole bunch of f64 piglit tests to fail for the radeonsi nir backend. e.g. ./bin/shader_runner generated_tests/spec/glsl-4.00/execution/built-in-functions/fs-inverse-dmat2.shader_test -auto -fbo LLVM ERRO

[Mesa-dev] [PATCH 05/15] ac: revert new LLVM 7.0 behavior for fdiv

2018-08-29 Thread Marek Olšák
From: Marek Olšák Cc: 18.1 18.2 --- src/amd/common/ac_llvm_build.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index c741a1ab62d..629cd2a7527 100644 --- a/src/amd/common/ac_llvm_build.c +++ b/src/amd