Re: [Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

2018-12-06 Thread Erik Faye-Lund
On Wed, 2018-11-21 at 12:04 +, Emil Velikov wrote: > From: Emil Velikov > > Otherwise the incorrect ones will be used, effecitvely breaking the > ABI. > > Note: some entries in static_data.py list a suffixed API, while (for > ES* > at least) we expect the one w/o suffix. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

2018-11-23 Thread Dylan Baker
Quoting Emil Velikov (2018-11-23 05:35:31) > On 2018/11/21, Dylan Baker wrote: > > Quoting Emil Velikov (2018-11-21 04:04:03) > > > > > > > +import os > > > +GLAPI = os.path.join(os.path.dirname(sys.argv[0]), "..", "glapi/gen") > > > > you should use __file__ instead of sys.argv[0], also don't

Re: [Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

2018-11-23 Thread Emil Velikov
On 2018/11/21, Dylan Baker wrote: > Quoting Emil Velikov (2018-11-21 04:04:03) > > > > +import os > > +GLAPI = os.path.join(os.path.dirname(sys.argv[0]), "..", "glapi/gen") > > you should use __file__ instead of sys.argv[0], also don't hardcode '/' into > there, join 'glapi' and 'gen' for windo

Re: [Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

2018-11-21 Thread Dylan Baker
Quoting Emil Velikov (2018-11-21 04:04:03) > From: Emil Velikov > > Otherwise the incorrect ones will be used, effecitvely breaking the ABI. > > Note: some entries in static_data.py list a suffixed API, while (for ES* > at least) we expect the one w/o suffix. > > Signed-off-by: Emil Velikov >

[Mesa-dev] [PATCH 06/18] mapi/new: use the static_data offsets in the new generator

2018-11-21 Thread Emil Velikov
From: Emil Velikov Otherwise the incorrect ones will be used, effecitvely breaking the ABI. Note: some entries in static_data.py list a suffixed API, while (for ES* at least) we expect the one w/o suffix. Signed-off-by: Emil Velikov --- src/mapi/new/genCommon.py | 30 +