Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-18 Thread Nanley Chery
On Mon, Jan 15, 2018 at 03:29:07PM +0200, Pohjolainen, Topi wrote: > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > > Sorry for all the list spam, but I'm sort of thinking out-loud and writing > > it on the list for all to read. > > > > I'm thinking that what we want this list t

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-18 Thread Nanley Chery
On Tue, Jan 16, 2018 at 10:21:44PM -0800, Jason Ekstrand wrote: > On Tue, Jan 16, 2018 at 4:30 PM, Nanley Chery wrote: > > > On Tue, Jan 16, 2018 at 12:02:43PM -0800, Nanley Chery wrote: > > > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > > > > Sorry for all the list spam, but

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-16 Thread Jason Ekstrand
On Tue, Jan 16, 2018 at 4:30 PM, Nanley Chery wrote: > On Tue, Jan 16, 2018 at 12:02:43PM -0800, Nanley Chery wrote: > > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > > > Sorry for all the list spam, but I'm sort of thinking out-loud and > writing > > > it on the list for all

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-16 Thread Nanley Chery
On Tue, Jan 16, 2018 at 12:02:43PM -0800, Nanley Chery wrote: > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > > Sorry for all the list spam, but I'm sort of thinking out-loud and writing > > it on the list for all to read. > > > > I'm thinking that what we want this list to ret

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-16 Thread Nanley Chery
On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > Sorry for all the list spam, but I'm sort of thinking out-loud and writing > it on the list for all to read. > > I'm thinking that what we want this list to return is not a bool but an enum > > /* The ordering of this enum is impor

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-15 Thread Pohjolainen, Topi
On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > Sorry for all the list spam, but I'm sort of thinking out-loud and writing > it on the list for all to read. > > I'm thinking that what we want this list to return is not a bool but an enum > > /* The ordering of this enum is impor

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-13 Thread Jason Ekstrand
Sorry for all the list spam, but I'm sort of thinking out-loud and writing it on the list for all to read. I'm thinking that what we want this list to return is not a bool but an enum /* The ordering of this enum is important */ enum anv_fast_clear_support { ANV_FAST_CLEAR_NONE = 0, ANV_FAS

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-12 Thread Jason Ekstrand
I made a table to help visualize all the different cases: Layout | compression | zero clear | non-zero clear +=++ GENERAL | N | N | N +-

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-12 Thread Jason Ekstrand
On Wed, Dec 13, 2017 at 11:26 AM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:05:56PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_image.c | 58 ++ > > > src/intel/vulkan/anv_private.h | 5 > > 2 files changed, 63 insertions(

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2017-12-13 Thread Nanley Chery
On Mon, Nov 27, 2017 at 07:05:56PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 58 > ++ > src/intel/vulkan/anv_private.h | 5 > 2 files changed, 63 insertions(+) > > diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulk

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2017-11-29 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:05:56PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 58 > ++ > src/intel/vulkan/anv_private.h | 5 > 2 files changed, 63 insertions(+) This seems to be pretty much inline with anv_layout_to_aux_usa

[Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2017-11-27 Thread Jason Ekstrand
--- src/intel/vulkan/anv_image.c | 58 ++ src/intel/vulkan/anv_private.h | 5 2 files changed, 63 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index a872149..561da28 100644 --- a/src/intel/vulkan/anv_image.c