Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2015-03-09 Thread Samuel Pitoiset
On 03/09/2015 11:00 PM, Marek Olšák wrote: If you plan to add more functions, this file can stay. Yes, it's my plan. Marek On Mon, Mar 9, 2015 at 10:54 PM, Samuel Pitoiset wrote: On 03/09/2015 10:43 PM, Marek Olšák wrote: It would be better to add this function to u_helpers.c/.h inste

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2015-03-09 Thread Marek Olšák
If you plan to add more functions, this file can stay. Marek On Mon, Mar 9, 2015 at 10:54 PM, Samuel Pitoiset wrote: > > > On 03/09/2015 10:43 PM, Marek Olšák wrote: >> >> It would be better to add this function to u_helpers.c/.h instead of >> adding new files. > > > Mmh, I'll probably introduce

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2015-03-09 Thread Samuel Pitoiset
On 03/09/2015 10:43 PM, Marek Olšák wrote: It would be better to add this function to u_helpers.c/.h instead of adding new files. Mmh, I'll probably introduce other functions related to queries when nouveau-perfkit will be ready. Are you sure it's a good idea to drop this file? Marek On

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2015-03-09 Thread Marek Olšák
It would be better to add this function to u_helpers.c/.h instead of adding new files. Marek On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset wrote: > This function can be used to get a generic group of driver-specific > queries when a driver doesn't expose any groups. > > Signed-off-by: Samuel

[Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2015-03-09 Thread Samuel Pitoiset
This function can be used to get a generic group of driver-specific queries when a driver doesn't expose any groups. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 50 ++ src/gallium/auxil

[Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info v2

2014-07-11 Thread Samuel Pitoiset
This generic function will be used to get groups of queries. V2: - add some comments as request by Brian Paul - put the function name on the next line Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 50

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2014-07-09 Thread Samuel Pitoiset
On 07/09/2014 03:00 PM, Brian Paul wrote: On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This generic function will be used to get groups of queries. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 46 ++

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2014-07-09 Thread Brian Paul
On 07/09/2014 08:34 AM, Samuel Pitoiset wrote: This generic function will be used to get groups of queries. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 46 ++ src/gallium/auxiliary

[Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

2014-07-09 Thread Samuel Pitoiset
This generic function will be used to get groups of queries. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 46 ++ src/gallium/auxiliary/util/u_query.h | 44 +