Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

2018-05-20 Thread Timothy Arceri
On 21/05/18 10:38, Dieter Nützel wrote: Hello Tim, progress on this one? I believe Matt was working on a series that uses these changes as a base. The series was never fully reviewed and it didn't help as much with radeonsi compile times as I'd hoped so I'll let Matt push/review this if he

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

2018-05-20 Thread Dieter Nützel
Hello Tim, progress on this one? Happy Pentecost! Dieter Am 10.04.2018 06:34, schrieb Timothy Arceri: --- src/compiler/glsl/glsl_to_nir.cpp | 20 1 file changed, 20 insertions(+) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

2018-04-11 Thread Jason Ekstrand
On Tue, Apr 10, 2018 at 10:26 PM, Timothy Arceri wrote: > > On 11/04/18 15:05, Jason Ekstrand wrote: > >> If I understand correctly, this is because when running with minimal GLSL >> IR, opt_function_inlining doesn't acutally inline them all. Is that >> correct? If so,

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

2018-04-10 Thread Timothy Arceri
On 11/04/18 15:05, Jason Ekstrand wrote: If I understand correctly, this is because when running with minimal GLSL IR, opt_function_inlining doesn't acutally inline them all.  Is that correct?  If so, would it make sense to just repeatedly call do_function_inlining until it stops making

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

2018-04-10 Thread Jason Ekstrand
If I understand correctly, this is because when running with minimal GLSL IR, opt_function_inlining doesn't acutally inline them all. Is that correct? If so, would it make sense to just repeatedly call do_function_inlining until it stops making progress when we're running with minimal

Re: [Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

2018-04-10 Thread Dieter Nützel
For the series (except 9-10): Tested-by: Dieter Nützel with glmark2, UH, UV and KDE Plasma 5 on RX580 Dieter Am 10.04.2018 06:34, schrieb Timothy Arceri: --- src/compiler/glsl/glsl_to_nir.cpp | 20 1 file changed, 20 insertions(+) diff --git

[Mesa-dev] [PATCH 08/10] glsl: use NIR function inlining for drivers that use glsl_to_nir

2018-04-09 Thread Timothy Arceri
--- src/compiler/glsl/glsl_to_nir.cpp | 20 1 file changed, 20 insertions(+) diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp index 5a36963607e..55c01024669 100644 --- a/src/compiler/glsl/glsl_to_nir.cpp +++