Re: [Mesa-dev] [PATCH 08/14] glsl: refactor duplicated validations between 2 layout-qualifiers

2016-11-25 Thread Andres Gomez
On Fri, 2016-11-25 at 11:07 +1100, Timothy Arceri wrote: > Thanks. Thanks for your patience with the review! ☺ > Patches 7 & 8 are: > > Reviewed-by: Timothy Arceri Pushing! -- Br, Andres ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 08/14] glsl: refactor duplicated validations between 2 layout-qualifiers

2016-11-24 Thread Timothy Arceri
Thanks. Patches 7 & 8 are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 08/14] glsl: refactor duplicated validations between 2 layout-qualifiers

2016-11-23 Thread Andres Gomez
Several layout-qualifier validations are duplicated in the merge_qualifier and validate_in_qualifier methods. We would rather have them refactored into single calls. Suggested by Timothy. Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_type.cpp | 126