Re: [Mesa-dev] [PATCH 09/19] radv: remove radv_layout_is_htile_compressed()

2017-10-02 Thread Samuel Pitoiset
On 10/01/2017 11:49 PM, Bas Nieuwenhuizen wrote: I'd like to keep this because they specify different concepts: has_htile is whether the htile metadata is valid in combination with the image data, i.e. we can enable htile reads if we want, and don't have to . is_htile_compressed is whether we

Re: [Mesa-dev] [PATCH 09/19] radv: remove radv_layout_is_htile_compressed()

2017-10-01 Thread Bas Nieuwenhuizen
I'd like to keep this because they specify different concepts: has_htile is whether the htile metadata is valid in combination with the image data, i.e. we can enable htile reads if we want, and don't have to . is_htile_compressed is whether we cannot read the data without the htile metadata.

[Mesa-dev] [PATCH 09/19] radv: remove radv_layout_is_htile_compressed()

2017-09-29 Thread Samuel Pitoiset
Similar to radv_layout_has_htile(). Also remove an assertion which was always false. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 12 +--- src/amd/vulkan/radv_image.c | 10 -- src/amd/vulkan/radv_meta_clear.c | 4 ++--