Re: [Mesa-dev] [PATCH 09/28] nir/algebraic: fix (inf - inf) = NaN case

2018-12-05 Thread Connor Abbott
This is not acceptable, since this will disable the optimization even when it would otherwise be allowed. Either we need to mark everything as precise if one of these execution modes are enabled, or we need to disable this optimization only if the appropriate preserve-NaN-and-Inf mode is set. On

[Mesa-dev] [PATCH 09/28] nir/algebraic: fix (inf - inf) = NaN case

2018-12-05 Thread Samuel Iglesias Gonsálvez
If we have (inf - inf) we should return NaN, not 0.0. Same for (NaN - NaN) case. Fixes tests in Vulkan CTS that produce such kind subtractions. Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_opt_algebraic.py | 2 -- 1 file changed, 2 deletions(-) diff --git