This is correct. However, it's probably better to just replace most of
that code with a call to nir_variable_create which will do everything in
that block except set the data.read_only bit including the strdup
(properly) and adding it to the list.
--Jason
On Mon, Feb 25, 2019 at 3:06 AM Tapani
Yep, confirmed that this plugs the leak.
FWIW there seems to be also "Conditional jump or move depends on
uninitialised value(s)" from valgrind but that is for something different.
Reviewed-by: Tapani Pälli
On 2/21/19 11:09 AM, Matthias Lorenz wrote:
Fixes: 3d7611e9 "st/nir: use NIR for
Fixes: 3d7611e9 "st/nir: use NIR for asm programs"
---
src/mesa/program/prog_to_nir.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c
index 312b299361e..6e3fa9432a3 100644
--- a/src/mesa/program/prog_to_nir.c