Re: [Mesa-dev] [PATCH 1/1] vulkan/wsi: Destroy swapchain images after terminating FIFO queues

2018-06-08 Thread Alex Smith
Thanks, I've pushed it. On 8 June 2018 at 10:38, Lionel Landwerlin wrote: > Sorry for missing that. > > Fixes: e73d136a023080 ("vulkan/wsi/x11: Implement FIFO mode.") > Reviewed-by: Lionel Landwerlin > > > On 01/06/18 12:16, Cameron Kumar wrote: > >> The queue_manager thread can access the

Re: [Mesa-dev] [PATCH 1/1] vulkan/wsi: Destroy swapchain images after terminating FIFO queues

2018-06-08 Thread Lionel Landwerlin
Sorry for missing that. Fixes: e73d136a023080 ("vulkan/wsi/x11: Implement FIFO mode.") Reviewed-by: Lionel Landwerlin On 01/06/18 12:16, Cameron Kumar wrote: The queue_manager thread can access the images from x11_present_to_x11, hence this reorder prevents dereferencing of dangling pointers.

Re: [Mesa-dev] [PATCH 1/1] vulkan/wsi: Destroy swapchain images after terminating FIFO queues

2018-06-08 Thread Alex Smith
Any feedback on this? On 1 June 2018 at 12:16, Cameron Kumar wrote: > The queue_manager thread can access the images from x11_present_to_x11, > hence this reorder prevents dereferencing of dangling pointers. > > Cc: "18.1" > --- > src/vulkan/wsi/wsi_common_x11.c | 6 +++--- > 1 file changed,

[Mesa-dev] [PATCH 1/1] vulkan/wsi: Destroy swapchain images after terminating FIFO queues

2018-06-04 Thread Cameron Kumar
The queue_manager thread can access the images from x11_present_to_x11, hence this reorder prevents dereferencing of dangling pointers. Cc: "18.1" --- src/vulkan/wsi/wsi_common_x11.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_x11.c