Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-03 Thread Chad Versace
On 10/01/2013 04:48 PM, Ben Widawsky wrote: On Tue, Oct 01, 2013 at 01:06:02PM -0700, Chad Versace wrote: On 09/30/2013 12:35 PM, Ben Widawsky wrote: diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.cpp b/src/mesa/drivers/dri/i965/gen6_blorp.cpp index da523e5..fc3a331 100644 --- a/src/mesa/

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-03 Thread Chad Versace
On 10/01/2013 04:36 PM, Ben Widawsky wrote: On Tue, Oct 01, 2013 at 01:06:02PM -0700, Chad Versace wrote: On 09/30/2013 12:35 PM, Ben Widawsky wrote: Starting with Ivybridge, the hierarchical had relaxed requirements for its allocation. Following a "simple" formula in the bspec was all you need

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-01 Thread Ben Widawsky
On Tue, Oct 01, 2013 at 01:06:02PM -0700, Chad Versace wrote: > On 09/30/2013 12:35 PM, Ben Widawsky wrote: > >Starting with Ivybridge, the hierarchical had relaxed requirements for > >its allocation. Following a "simple" formula in the bspec was all you > >needed to satisfy the requirement. > > >

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-01 Thread Ben Widawsky
On Tue, Oct 01, 2013 at 03:46:14PM -0700, Matt Turner wrote: > On Mon, Sep 30, 2013 at 12:35 PM, Ben Widawsky > wrote: > > Starting with Ivybridge, the hierarchical had relaxed requirements for > > its allocation. > > This reads badly. How about > > The HiZ buffer's allocation requirements were

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-01 Thread Ben Widawsky
On Tue, Oct 01, 2013 at 01:06:02PM -0700, Chad Versace wrote: > On 09/30/2013 12:35 PM, Ben Widawsky wrote: > >Starting with Ivybridge, the hierarchical had relaxed requirements for > >its allocation. Following a "simple" formula in the bspec was all you > >needed to satisfy the requirement. > > >

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-01 Thread Matt Turner
On Mon, Sep 30, 2013 at 12:35 PM, Ben Widawsky wrote: > Starting with Ivybridge, the hierarchical had relaxed requirements for > its allocation. This reads badly. How about The HiZ buffer's allocation requirements were relaxed on Ivybridge. ___ mesa-de

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-01 Thread Chad Versace
On 09/30/2013 12:35 PM, Ben Widawsky wrote: Starting with Ivybridge, the hierarchical had relaxed requirements for its allocation. Following a "simple" formula in the bspec was all you needed to satisfy the requirement. To prepare the code for this, extract all places where the miptree was used,

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-09-30 Thread Ben Widawsky
On Mon, Sep 30, 2013 at 07:24:08PM -0700, Ian Romanick wrote: > On 09/30/2013 12:35 PM, Ben Widawsky wrote: > > Starting with Ivybridge, the hierarchical had relaxed requirements for > > its allocation. Following a "simple" formula in the bspec was all you > > needed to satisfy the requirement. > >

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-09-30 Thread Ian Romanick
On 09/30/2013 12:35 PM, Ben Widawsky wrote: > Starting with Ivybridge, the hierarchical had relaxed requirements for > its allocation. Following a "simple" formula in the bspec was all you > needed to satisfy the requirement. > > To prepare the code for this, extract all places where the miptree w

[Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-09-30 Thread Ben Widawsky
Starting with Ivybridge, the hierarchical had relaxed requirements for its allocation. Following a "simple" formula in the bspec was all you needed to satisfy the requirement. To prepare the code for this, extract all places where the miptree was used, when we really only needed the region. This a