Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-09 Thread Dave Airlie
On Sat, Feb 8, 2014 at 10:22 PM, Christoph Bumiller wrote: > On 07.02.2014 23:25, Dave Airlie wrote: Doh, yes because GL has ARB_texture_gather then has stuff hidden away in ARB_gpu_shader5 I forgot to add the extra bits which I suppose we should do. So I've reposted with

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-08 Thread Christoph Bumiller
On 07.02.2014 23:25, Dave Airlie wrote: >>> Doh, yes because GL has ARB_texture_gather then has stuff hidden away >>> in ARB_gpu_shader5 I forgot to add the extra bits which I suppose we should >>> do. >>> >>> So I've reposted with the component selection in src1 now. >> Hmm seems a bit excessive

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-07 Thread Roland Scheidegger
Am 07.02.2014 23:25, schrieb Dave Airlie: >>> Doh, yes because GL has ARB_texture_gather then has stuff hidden away >>> in ARB_gpu_shader5 I forgot to add the extra bits which I suppose we should >>> do. >>> >>> So I've reposted with the component selection in src1 now. >> >> Hmm seems a bit

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-07 Thread Dave Airlie
>>> >> Doh, yes because GL has ARB_texture_gather then has stuff hidden away >> in ARB_gpu_shader5 I forgot to add the extra bits which I suppose we should >> do. >> >> So I've reposted with the component selection in src1 now. > > Hmm seems a bit excessive to use an extra reg for that (gather4 bu

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-07 Thread Roland Scheidegger
Am 07.02.2014 04:37, schrieb Dave Airlie: > On Fri, Feb 7, 2014 at 12:36 PM, Roland Scheidegger > wrote: >> Am 07.02.2014 02:56, schrieb Ilia Mirkin: >>> On Thu, Feb 6, 2014 at 8:52 PM, Dave Airlie wrote: From: Dave Airlie This just adds the TG4 opcode, and a CAP for the max

[Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-06 Thread Dave Airlie
From: Dave Airlie This just adds the TG4 opcode, and a CAP for the max texture gather components. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_info.c | 1 + src/gallium/include/pipe/p_defines.h | 3 ++- src/gallium/include/pipe/p_shader_tokens.h | 4 +++- 3 files ch

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-06 Thread Roland Scheidegger
Am 07.02.2014 02:56, schrieb Ilia Mirkin: > On Thu, Feb 6, 2014 at 8:52 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> This just adds the TG4 opcode, and a CAP for the >> max texture gather components. > > Is this different from GATHER4? If it is, should probably be > documented in docs/sourc

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-06 Thread Dave Airlie
On Fri, Feb 7, 2014 at 12:36 PM, Roland Scheidegger wrote: > Am 07.02.2014 02:56, schrieb Ilia Mirkin: >> On Thu, Feb 6, 2014 at 8:52 PM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> This just adds the TG4 opcode, and a CAP for the >>> max texture gather components. >> >> Is this different f

[Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium (v2)

2014-02-06 Thread Dave Airlie
From: Dave Airlie This just adds the TG4 opcode, and a CAP for the max texture gather components. v2: add component selection src and a cap to say hw can do it. (st can use to help control GL_ARB_gpu_shader5/GLSL 4.00). Add docs. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_

Re: [Mesa-dev] [PATCH 1/2] gallium: add texture gather support to gallium

2014-02-06 Thread Ilia Mirkin
On Thu, Feb 6, 2014 at 8:52 PM, Dave Airlie wrote: > From: Dave Airlie > > This just adds the TG4 opcode, and a CAP for the > max texture gather components. Is this different from GATHER4? If it is, should probably be documented in docs/source/tgsi.rst... > > Signed-off-by: Dave Airlie > --- >