Re: [Mesa-dev] [PATCH 1/2] glsl: Add blob.c---a simple interface for serializing data

2014-12-12 Thread Jason Ekstrand
On Fri, Dec 12, 2014 at 2:37 PM, Carl Worth wrote: > > On Thu, Dec 11 2014, Jason Ekstrand wrote: > > Yeah, this looks nifty. > > Thanks! > > > I've got some comments on the implementation though. > > I really appreciate the careful review. I obviously didn't pay quite as > much attention to detai

Re: [Mesa-dev] [PATCH 1/2] glsl: Add blob.c---a simple interface for serializing data

2014-12-12 Thread Carl Worth
On Thu, Dec 11 2014, Jason Ekstrand wrote: > Yeah, this looks nifty. Thanks! > I've got some comments on the implementation though. I really appreciate the careful review. I obviously didn't pay quite as much attention to detail as I would like to when writing this patch. I'm glad I didn't bury

Re: [Mesa-dev] [PATCH 1/2] glsl: Add blob.c---a simple interface for serializing data

2014-12-11 Thread Jason Ekstrand
Hey Carl, Yeah, this looks nifty. I've got some comments on the implementation though. On Dec 11, 2014 11:55 AM, "Carl Worth" wrote: > > This new interface allows for writing a series of objects to a chunk > of memory (a "blob").. The allocated memory is maintained within the > blob itself, (and

[Mesa-dev] [PATCH 1/2] glsl: Add blob.c---a simple interface for serializing data

2014-12-11 Thread Carl Worth
This new interface allows for writing a series of objects to a chunk of memory (a "blob").. The allocated memory is maintained within the blob itself, (and re-allocated by doubling when necessary). There are also functions for reading objects from a blob as well. If code attempts to read beyond th