Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-23 Thread Brian Paul
On 10/21/2011 07:34 PM, Ian Romanick wrote: On 10/21/2011 12:53 PM, Brian Paul wrote: On 10/21/2011 01:23 PM, Brian Paul wrote: On 10/21/2011 12:49 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com Setting this flag prevents declarations of uniforms from being removed from

[Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by several API functions that query uniforms in shaders, uniform declarations cannot be removed after the locations have been set.

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Bryan Cain
If it's worth anything, the glsl_to_tgsi part is Reviewed-by: Bryan Cain bryanca...@gmail.com On 10/21/2011 01:49 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Brian Paul
On 10/21/2011 12:49 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by several API functions that query uniforms in shaders, uniform declarations cannot be

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Brian Paul
On 10/21/2011 01:23 PM, Brian Paul wrote: On 10/21/2011 12:49 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by several API functions that query uniforms in

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Kenneth Graunke
On 10/21/2011 11:49 AM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by several API functions that query uniforms in shaders, uniform declarations cannot be

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Ian Romanick
On 10/21/2011 12:53 PM, Brian Paul wrote: On 10/21/2011 01:23 PM, Brian Paul wrote: On 10/21/2011 12:49 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by