Re: [Mesa-dev] [PATCH 1/2] i965: Don't use a temporary when generating an indirect sample

2015-06-01 Thread Neil Roberts
Many thanks for all the reviews and testing. I've pushed the two patches. The remaining sampler_array_indexing tests that fail on SKL (the gs ones) are because of a separate problem described in this patch: http://patchwork.freedesktop.org/patch/50676/ I'm not really sure whether that's the clea

Re: [Mesa-dev] [PATCH 1/2] i965: Don't use a temporary when generating an indirect sample

2015-05-29 Thread Anuj Phogat
On Fri, May 29, 2015 at 6:53 AM, Neil Roberts wrote: > Previously when generating the send instruction for a sample > instruction with an indirect sampler it would use the destination > register as a temporary store. This breaks when used in combination > with the opt_sampler_eot optimisation beca

Re: [Mesa-dev] [PATCH 1/2] i965: Don't use a temporary when generating an indirect sample

2015-05-29 Thread Chris Forbes
This thing has been trouble since I wrote it. Nice to see it go. Both patches are: Reviewed-by: Chris Forbes On May 30, 2015 6:28 AM, "Matt Turner" wrote: > On Fri, May 29, 2015 at 6:53 AM, Neil Roberts > wrote: > > Previously when generating the send instruction for a sample > > instruction

Re: [Mesa-dev] [PATCH 1/2] i965: Don't use a temporary when generating an indirect sample

2015-05-29 Thread Matt Turner
On Fri, May 29, 2015 at 6:53 AM, Neil Roberts wrote: > Previously when generating the send instruction for a sample > instruction with an indirect sampler it would use the destination > register as a temporary store. This breaks when used in combination > with the opt_sampler_eot optimisation beca

[Mesa-dev] [PATCH 1/2] i965: Don't use a temporary when generating an indirect sample

2015-05-29 Thread Neil Roberts
Previously when generating the send instruction for a sample instruction with an indirect sampler it would use the destination register as a temporary store. This breaks when used in combination with the opt_sampler_eot optimisation because that forces the destination to be null. This patch fixes t