Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-11-19 Thread andrey simiklit
On Tue, Jan 8, 2019 at 11:01 PM Chris Wilson wrote: > Quoting Kenneth Graunke (2019-01-08 20:17:01) > > On Tuesday, January 8, 2019 3:11:37 AM PST Chris Wilson wrote: > > > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > > > Hi Andrii, > > > > > > > > Although I think what these patches do

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Chris Wilson
Quoting Kenneth Graunke (2019-01-08 20:17:01) > On Tuesday, January 8, 2019 3:11:37 AM PST Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > > Hi Andrii, > > > > > > Although I think what these patches do makes sense, I think it's missing > > > the bigger picture. > > >

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Kenneth Graunke
On Tuesday, January 8, 2019 3:11:37 AM PST Chris Wilson wrote: > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > Hi Andrii, > > > > Although I think what these patches do makes sense, I think it's missing > > the bigger picture. > > There is a lot more state that gets lost if we have to

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread andrey simiklit
On Tue, Jan 8, 2019 at 6:16 PM Chris Wilson wrote: > Quoting andrey simiklit (2019-01-08 16:00:45) > > On Tue, Jan 8, 2019 at 1:11 PM Chris Wilson > wrote: > > > > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > > Hi Andrii, > > > > > > Although I think what these patches do

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Chris Wilson
Quoting andrey simiklit (2019-01-08 16:00:45) > On Tue, Jan 8, 2019 at 1:11 PM Chris Wilson wrote: > > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > Hi Andrii, > > > > Although I think what these patches do makes sense, I think it's missing > > the bigger picture. >

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread andrey simiklit
On Tue, Jan 8, 2019 at 1:11 PM Chris Wilson wrote: > Quoting Lionel Landwerlin (2019-01-08 11:03:26) > > Hi Andrii, > > > > Although I think what these patches do makes sense, I think it's missing > > the bigger picture. > > There is a lot more state that gets lost if we have to revert all of

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Lionel Landwerlin
On 08/01/2019 11:11, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-01-08 11:03:26) Hi Andrii, Although I think what these patches do makes sense, I think it's missing the bigger picture. There is a lot more state that gets lost if we have to revert all of the emitted commands. A quick

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-01-08 11:03:26) > Hi Andrii, > > Although I think what these patches do makes sense, I think it's missing > the bigger picture. > There is a lot more state that gets lost if we have to revert all of the > emitted commands. > A quick look at

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread Lionel Landwerlin
Hi Andrii, Although I think what these patches do makes sense, I think it's missing the bigger picture. There is a lot more state that gets lost if we have to revert all of the emitted commands. A quick look at brw_upload_pipeline_state() shows all of the programs could be invalid as well, or

Re: [Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2019-01-08 Thread andrey simiklit
Hi all, Could somebody take a look at this patch? Regards, Andrii. On Mon, Nov 19, 2018 at 11:19 PM wrote: > From: Andrii Simiklit > > This patch is needed to avoid missing 3DSTATE_URB_* commands in a batch > after > rollback operation. > > To be able to test easily this issue > the

[Mesa-dev] [PATCH 1/2] i965: add missing rollback of URB requirements

2018-11-19 Thread asimiklit . work
From: Andrii Simiklit This patch is needed to avoid missing 3DSTATE_URB_* commands in a batch after rollback operation. To be able to test easily this issue the following workaround is necessary: -if (!brw_batch_has_aperture_space(brw, 0)) { by: +if (true) { in brw_draw_single_prim function.