Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

2017-11-20 Thread Ian Romanick
On 11/20/2017 04:12 AM, Emil Velikov wrote: > Hi Scott, > > I think there's a few missed checks if the extensions is enabled. > > On 14 November 2017 at 22:54, Scott D Phillips > wrote: > >> @@ -218,6 +218,7 @@ _legal_parameters(struct gl_context *ctx, GLenum

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

2017-11-20 Thread Emil Velikov
Hi Scott, I think there's a few missed checks if the extensions is enabled. On 14 November 2017 at 22:54, Scott D Phillips wrote: > @@ -218,6 +218,7 @@ _legal_parameters(struct gl_context *ctx, GLenum target, > GLenum internalformat, > case

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

2017-11-16 Thread Ian Romanick
On 11/16/2017 11:57 AM, Ilia Mirkin wrote: > On Thu, Nov 16, 2017 at 2:49 PM, Ian Romanick wrote: >> On 11/14/2017 02:54 PM, Scott D Phillips wrote: >>> This extension provides a new texture and sampler parameter >>> (TEXTURE_REDUCTION_MODE_ARB) which allows applications to

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

2017-11-16 Thread Ilia Mirkin
On Thu, Nov 16, 2017 at 2:57 PM, Ilia Mirkin wrote: > On Thu, Nov 16, 2017 at 2:49 PM, Ian Romanick wrote: >> On 11/14/2017 02:54 PM, Scott D Phillips wrote: >>> This extension provides a new texture and sampler parameter >>>

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

2017-11-16 Thread Ilia Mirkin
On Thu, Nov 16, 2017 at 2:49 PM, Ian Romanick wrote: > On 11/14/2017 02:54 PM, Scott D Phillips wrote: >> This extension provides a new texture and sampler parameter >> (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce >> a filtered texel value by computing a

Re: [Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

2017-11-16 Thread Ian Romanick
On 11/14/2017 02:54 PM, Scott D Phillips wrote: > This extension provides a new texture and sampler parameter > (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce > a filtered texel value by computing a component-wise minimum (MIN) > or maximum (MAX) of the texels that would

[Mesa-dev] [PATCH 1/2] mesa: Implement ARB_texture_filter_minmax

2017-11-14 Thread Scott D Phillips
This extension provides a new texture and sampler parameter (TEXTURE_REDUCTION_MODE_ARB) which allows applications to produce a filtered texel value by computing a component-wise minimum (MIN) or maximum (MAX) of the texels that would normally be averaged. --- CTS tests