Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

2018-07-30 Thread Eric Anholt
Tapani Pälli writes: > Hi; > > > On 07/25/2018 08:36 AM, Tapani Pälli wrote: >> >> >> On 07/24/2018 10:31 PM, Eric Anholt wrote: >>> Tapani Pälli writes: >>> These bits were missing, found when extending the Piglit test. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension p

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

2018-07-29 Thread Tapani Pälli
Hi; On 07/25/2018 08:36 AM, Tapani Pälli wrote: On 07/24/2018 10:31 PM, Eric Anholt wrote: Tapani Pälli writes: These bits were missing, found when extending the Piglit test. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" Signed-off-by: Tapani Pälli Aren't you miss

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

2018-07-24 Thread Tapani Pälli
On 07/24/2018 10:31 PM, Eric Anholt wrote: Tapani Pälli writes: These bits were missing, found when extending the Piglit test. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" Signed-off-by: Tapani Pälli Aren't you missing the RGB16 and R/RG/RGB/RGBA16_SNORM cases here?

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

2018-07-24 Thread Tapani Pälli
On 07/25/2018 12:45 AM, Nanley Chery wrote: On Tue, Jul 24, 2018 at 08:58:20AM +0300, Tapani Pälli wrote: These bits were missing, found when extending the Piglit test. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" Signed-off-by: Tapani Pälli --- src/mesa/main/fbobject

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

2018-07-24 Thread Nanley Chery
On Tue, Jul 24, 2018 at 08:58:20AM +0300, Tapani Pälli wrote: > These bits were missing, found when extending the Piglit test. > > Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" > Signed-off-by: Tapani Pälli > --- > src/mesa/main/fbobject.c | 10 +++--- > 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

2018-07-24 Thread Eric Anholt
Tapani Pälli writes: > These bits were missing, found when extending the Piglit test. > > Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" > Signed-off-by: Tapani Pälli Aren't you missing the RGB16 and R/RG/RGB/RGBA16_SNORM cases here? They aren't required for rendering, but

[Mesa-dev] [PATCH 1/2] mesa: add glRenderbufferStorage support for EXT_texture_norm16 formats

2018-07-23 Thread Tapani Pälli
These bits were missing, found when extending the Piglit test. Fixes: 7f467d4f73 "mesa: GL_EXT_texture_norm16 extension plumbing" Signed-off-by: Tapani Pälli --- src/mesa/main/fbobject.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src