Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-07 Thread Erik Faye-Lund
On Thu, Jul 7, 2016 at 7:01 PM, Connor Abbott wrote: > On Thu, Jul 7, 2016 at 12:57 PM, Erik Faye-Lund wrote: >> On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: >>> This was appearing in vc4 VS/CS in mupen64, due to vertex attrib

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-07 Thread Connor Abbott
On Thu, Jul 7, 2016 at 12:57 PM, Erik Faye-Lund wrote: > On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: >> This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering >> producing some constants that were getting compared. >> >> total

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-07 Thread Erik Faye-Lund
On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: > This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering > producing some constants that were getting compared. > > total instructions in shared programs: 112276 -> 112198 (-0.07%) > instructions in affected

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-06 Thread Jason Ekstrand
Looks good to me Reviewed-by: Jason Ekstrand On Wed, Jul 6, 2016 at 5:12 PM, Eric Anholt wrote: > This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering > producing some constants that were getting compared. > > total instructions in

[Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-06 Thread Eric Anholt
This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering producing some constants that were getting compared. total instructions in shared programs: 112276 -> 112198 (-0.07%) instructions in affected programs: 2239 -> 2161 (-3.48%) total estimated cycles in shared programs: