Re: [Mesa-dev] [PATCH 1/2] nir: update nir_lower_returns to only predicate instructions when needed

2016-12-21 Thread Jason Ekstrand
Ok... Different set of comments. Now, with less bogosity! On Mon, Dec 19, 2016 at 8:18 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > Unless an if statement contains nested returns we can simply add > any following instructions to the branch without the return. > > V2: fix handling

Re: [Mesa-dev] [PATCH 1/2] nir: update nir_lower_returns to only predicate instructions when needed

2016-12-20 Thread Timothy Arceri
On Tue, 2016-12-20 at 09:44 -0800, Jason Ekstrand wrote: > On Mon, Dec 19, 2016 at 8:18 PM, Timothy Arceri bora.com> wrote: > > Unless an if statement contains nested returns we can simply add > > any following instructions to the branch without the return. > > > > V2: fix

Re: [Mesa-dev] [PATCH 1/2] nir: update nir_lower_returns to only predicate instructions when needed

2016-12-20 Thread Jason Ekstrand
On Mon, Dec 19, 2016 at 8:18 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > Unless an if statement contains nested returns we can simply add > any following instructions to the branch without the return. > > V2: fix handling if_nested_return value when there is a sibling if/loop >

[Mesa-dev] [PATCH 1/2] nir: update nir_lower_returns to only predicate instructions when needed

2016-12-19 Thread Timothy Arceri
Unless an if statement contains nested returns we can simply add any following instructions to the branch without the return. V2: fix handling if_nested_return value when there is a sibling if/loop that doesn't contain a return. (Spotted by Ken) --- src/compiler/nir/nir_lower_returns.c | 37

Re: [Mesa-dev] [PATCH 1/2] nir: update nir_lower_returns to only predicate instructions when needed

2016-12-08 Thread Timothy Arceri
On Fri, 2016-12-09 at 16:49 +1100, Timothy Arceri wrote: > Unless an if statement contains nested returns we can simply add > any following instructions to the branch without the return. > --- >  src/compiler/nir/nir_lower_returns.c | 36 > ++-- >  1 file changed, 30

[Mesa-dev] [PATCH 1/2] nir: update nir_lower_returns to only predicate instructions when needed

2016-12-08 Thread Timothy Arceri
Unless an if statement contains nested returns we can simply add any following instructions to the branch without the return. --- src/compiler/nir/nir_lower_returns.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git