Re: [Mesa-dev] [PATCH 1/2] nvc0: clear out surfaces bufctx before rebinding everything

2016-05-19 Thread Samuel Pitoiset
On 05/19/2016 12:02 PM, Pierre Moreau wrote: On 09:28 PM - May 18 2016, Ilia Mirkin wrote: Otherwise we can end up in a situation where that bin just grows and grows. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 5 + 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] nvc0: clear out surfaces bufctx before rebinding everything

2016-05-19 Thread Ilia Mirkin
Yes, oops. Shouldn't fix any invalidation issues. Could fix unbounded memory growth due to switching back and forth between cp and 3d without setting any new images. Please fold this into your series. On May 19, 2016 4:13 AM, "Samuel Pitoiset" wrote: Oops? Your patch

Re: [Mesa-dev] [PATCH 1/2] nvc0: clear out surfaces bufctx before rebinding everything

2016-05-19 Thread Pierre Moreau
On 09:28 PM - May 18 2016, Ilia Mirkin wrote: > Otherwise we can end up in a situation where that bin just grows and > grows. > > Signed-off-by: Ilia Mirkin > --- > src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] nvc0: clear out surfaces bufctx before rebinding everything

2016-05-19 Thread Samuel Pitoiset
Oops? Your patch is based on your gl43 branch with my images series but this is not yet upstream. ;) Anyway, the idea sounds good to me and might explain some invalidation issues, perhaps? I'll have look later. On 05/19/2016 03:28 AM, Ilia Mirkin wrote: Otherwise we can end up in a

[Mesa-dev] [PATCH 1/2] nvc0: clear out surfaces bufctx before rebinding everything

2016-05-18 Thread Ilia Mirkin
Otherwise we can end up in a situation where that bin just grows and grows. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c