Re: [Mesa-dev] [PATCH 1/2] spirv: Add SpvCapabilityShaderViewportIndexLayerEXT

2018-02-09 Thread Iago Toral
On Fri, 2018-02-09 at 09:08 +0100, Iago Toral wrote: > On Sat, 2018-01-27 at 18:58 -0800, Caio Marcelo de Oliveira Filho > wrote: > > --- > > > > In the last chunk of the diff, should accepting stage of vertex > > shader > > should be conditioned on shader_viewport_index_layer? > > I was going

Re: [Mesa-dev] [PATCH 1/2] spirv: Add SpvCapabilityShaderViewportIndexLayerEXT

2018-02-09 Thread Iago Toral
On Sat, 2018-01-27 at 18:58 -0800, Caio Marcelo de Oliveira Filho wrote: > --- > > In the last chunk of the diff, should accepting stage of vertex > shader > should be conditioned on shader_viewport_index_layer? I was going to say that we should assert that shader_viewport_index_layer is

[Mesa-dev] [PATCH 1/2] spirv: Add SpvCapabilityShaderViewportIndexLayerEXT

2018-01-27 Thread Caio Marcelo de Oliveira Filho
--- In the last chunk of the diff, should accepting stage of vertex shader should be conditioned on shader_viewport_index_layer? src/compiler/shader_info.h | 1 + src/compiler/spirv/spirv_to_nir.c | 4 src/compiler/spirv/vtn_variables.c | 2 +- 3 files changed, 6 insertions(+), 1