Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

2015-10-29 Thread Julien Isorce
Ack. And I'll move this bit at the end just before the other FREE. Thx -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 12:22 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 1/2] st/va: impl

Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

2015-10-29 Thread Christian König
Patch #1: + if (buf->data) + FREE(buf->data); FREE() usually does a NULL check anyway. Apart from that minor nitpick the patch is Reviewed-by: Christian König Regards, Christian. On 29.10.2015 12:47, Julien Isorce wrote: And apply relatives change to: vlVaBufferSetNumElements vlVaCr

[Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

2015-10-29 Thread Julien Isorce
And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType which is normally used for normal user data arr