Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-19 Thread Emil Velikov
On 19 January 2018 at 14:46, Eric Engestrom wrote: > On Tuesday, 2018-01-16 18:35:40 +, Emil Velikov wrote: >> On 15 January 2018 at 22:03, Grazvydas Ignotas wrote: >> > Found with the help of following Coccinelle semantic patch: >> > // >> > @@

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-19 Thread Eric Engestrom
On Tuesday, 2018-01-16 18:35:40 +, Emil Velikov wrote: > On 15 January 2018 at 22:03, Grazvydas Ignotas wrote: > > Found with the help of following Coccinelle semantic patch: > > // > > @@ > > expression E; > > @@ > > > >

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Emil Velikov
On 15 January 2018 at 22:03, Grazvydas Ignotas wrote: > Found with the help of following Coccinelle semantic patch: > // > @@ > expression E; > @@ > > \(pthread_mutex_lock\|mtx_lock\|simple_mtx_lock\)(E) > ... > ( >

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Christian König
Am 16.01.2018 um 11:20 schrieb Grazvydas Ignotas: On Tue, Jan 16, 2018 at 10:15 AM, Christian König wrote: Reviewed-by: Christian König Do you have commit right by now or should Leo or I commit that for you? Yes I do. Of course

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Grazvydas Ignotas
On Tue, Jan 16, 2018 at 10:15 AM, Christian König wrote: > Reviewed-by: Christian König > > Do you have commit right by now or should Leo or I commit that for you? Yes I do. > > Thanks for the help, > Christian. > > > Am 15.01.2018 um

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Christian König
Reviewed-by: Christian König Do you have commit right by now or should Leo or I commit that for you? Thanks for the help, Christian. Am 15.01.2018 um 23:03 schrieb Grazvydas Ignotas: Found with the help of following Coccinelle semantic patch: // @@ expression E; @@

[Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-15 Thread Grazvydas Ignotas
Found with the help of following Coccinelle semantic patch: // @@ expression E; @@ \(pthread_mutex_lock\|mtx_lock\|simple_mtx_lock\)(E) ... ( \(pthread_mutex_unlock\|mtx_unlock\|simple_mtx_unlock\)(E); ... return ...; | + maybe need_unlock(E); return ...; ) // Signed-off-by: