Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

2017-03-16 Thread Emil Velikov
Hi Ben, On 13 March 2017 at 21:47, Ben Widawsky wrote: > On 17-03-10 10:28:42, Emil Velikov wrote: >> >> Hi Ben, >> >> Mostly pointing out a few things that look strange, pardon if some >> seem too pedantic. >> >> On 10 March 2017 at 01:48, Ben Widawsky wrote: >> >>> --- >>> include/GL/internal

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

2017-03-13 Thread Ben Widawsky
On 17-03-10 10:28:42, Emil Velikov wrote: Hi Ben, Mostly pointing out a few things that look strange, pardon if some seem too pedantic. On 10 March 2017 at 01:48, Ben Widawsky wrote: --- include/GL/internal/dri_interface.h | 27 ++- Split the Infra from the i965

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

2017-03-13 Thread Ben Widawsky
On 17-03-09 18:38:15, Jason Ekstrand wrote: On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky wrote: Modifiers will be obtains or guessed by the client and passed in during "obtained" Got it. image creation/import. This requires bumping the DRIimage version. As of this patch, the modifie

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

2017-03-10 Thread Emil Velikov
Hi Ben, Mostly pointing out a few things that look strange, pardon if some seem too pedantic. On 10 March 2017 at 01:48, Ben Widawsky wrote: > --- > include/GL/internal/dri_interface.h | 27 ++- Split the Infra from the i965 implementation ? > src/gallium/state_tr

Re: [Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

2017-03-09 Thread Jason Ekstrand
On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky wrote: > Modifiers will be obtains or guessed by the client and passed in during > "obtained" > image creation/import. > > This requires bumping the DRIimage version. > > As of this patch, the modifiers aren't plumbed all the way down, this > patch

[Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

2017-03-09 Thread Ben Widawsky
Modifiers will be obtains or guessed by the client and passed in during image creation/import. This requires bumping the DRIimage version. As of this patch, the modifiers aren't plumbed all the way down, this patch simply makes sure the interface level stuff is correct. v2: Don't allow usage + m