Re: [Mesa-dev] [PATCH 1/3] glsl: correctly handle conversions between int and uint

2011-04-19 Thread Bryan Cain
On 04/19/2011 05:43 PM, Ian Romanick wrote: > On 04/18/2011 04:51 PM, Bryan Cain wrote: > > This patch was revised several times before submitting, and even after > > that I still wasn't sure that adding conversion operations was the right > > solution. So I'm not really surprised that there are p

Re: [Mesa-dev] [PATCH 1/3] glsl: correctly handle conversions between int and uint

2011-04-19 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/18/2011 04:51 PM, Bryan Cain wrote: > This patch was revised several times before submitting, and even after > that I still wasn't sure that adding conversion operations was the right > solution. So I'm not really surprised that there are proble

Re: [Mesa-dev] [PATCH 1/3] glsl: correctly handle conversions between int and uint

2011-04-18 Thread Bryan Cain
This patch was revised several times before submitting, and even after that I still wasn't sure that adding conversion operations was the right solution. So I'm not really surprised that there are problems with this one. :) On 04/18/2011 06:36 PM, Ian Romanick wrote: > On 04/17/2011 11:39 PM, Bry

Re: [Mesa-dev] [PATCH 1/3] glsl: correctly handle conversions between int and uint

2011-04-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/17/2011 11:39 PM, Bryan Cain wrote: > From the GLSL 1.30 specification, section 4.1.10 ("Implicit Conversions"): > "There are no implicit conversions between signed and unsigned integers." > > However, convert_component() was assuming that c

Re: [Mesa-dev] [PATCH 1/3] glsl: correctly handle conversions between int and uint

2011-04-18 Thread Kenneth Graunke
On 04/17/2011 11:39 PM, Bryan Cain wrote: From the GLSL 1.30 specification, section 4.1.10 ("Implicit Conversions"): "There are no implicit conversions between signed and unsigned integers." However, convert_component() was assuming that conversions between int and uint were implicit. H

[Mesa-dev] [PATCH 1/3] glsl: correctly handle conversions between int and uint

2011-04-17 Thread Bryan Cain
>From the GLSL 1.30 specification, section 4.1.10 ("Implicit Conversions"): "There are no implicit conversions between signed and unsigned integers." However, convert_component() was assuming that conversions between int and uint were implicit. --- src/glsl/ast_function.cpp | 16