Re: [Mesa-dev] [PATCH 1/3] glsl: remove duplicate embedded struct validation

2016-02-11 Thread Iago Toral
Looks good to me, Reviewed-by: Iago Toral Quiroga On Thu, 2016-02-11 at 15:45 +1100, Timothy Arceri wrote: > Commit c98deb18d5836f in 2010 disallowed embedded struct definitions > in ES. Then in 2013 d9bb8b7b56ce65b disallowed it for everything but > GLSL 1.10. > > Commit

[Mesa-dev] [PATCH 1/3] glsl: remove duplicate embedded struct validation

2016-02-10 Thread Timothy Arceri
Commit c98deb18d5836f in 2010 disallowed embedded struct definitions in ES. Then in 2013 d9bb8b7b56ce65b disallowed it for everything but GLSL 1.10. Commit c98deb18d5836f seemed the cleanest way to do the check so its been extended to cover GL and the other version has been removed. Cc: Ian