Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Timothy Arceri
ets location 0 too. I > > > haven't quite > > > figured out yet where the issue is but the location counter gets > > > reset for > > > each array item and starts again from 0 while it should actually > > > maintain its > > > count .. > > >

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Samuel Iglesias Gonsálvez
Series is Reviewed-by: Samuel Iglesias Gonsálvez Thanks, Sam On 20/10/15 11:24, Tapani Pälli wrote: > UniformRemapTable is used only for remapping user specified uniform > locations to driver internally used ones, shader storage buffer > variables should not utilize uniform locations. > > Sig

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Lofstedt, Marta
> -Original Message- > From: Palli, Tapani > Sent: Tuesday, October 20, 2015 12:55 PM > To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling > UniformRemapTable > > > > On 10/20/

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Tapani Pälli
On 10/20/2015 01:40 PM, Lofstedt, Marta wrote: -Original Message- From: Palli, Tapani Sent: Tuesday, October 20, 2015 12:25 PM To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable On 10/20

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Lofstedt, Marta
> -Original Message- > From: Palli, Tapani > Sent: Tuesday, October 20, 2015 12:25 PM > To: Lofstedt, Marta; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling > UniformRemapTable > > > > On 10/20/

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Tapani Pälli
o:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tapani Pälli Sent: Tuesday, October 20, 2015 11:24 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable UniformRemapTable is used only for remapping user specified uniform locations to dr

Re: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Lofstedt, Marta
li > Sent: Tuesday, October 20, 2015 11:24 AM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling > UniformRemapTable > > UniformRemapTable is used only for remapping user specified uniform > locations to driver intern

[Mesa-dev] [PATCH 1/3] glsl: skip buffer variables when filling UniformRemapTable

2015-10-20 Thread Tapani Pälli
UniformRemapTable is used only for remapping user specified uniform locations to driver internally used ones, shader storage buffer variables should not utilize uniform locations. Signed-off-by: Tapani Pälli --- src/glsl/link_uniforms.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions