Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-26 Thread Timothy Arceri
On 26/04/18 23:41, Ian Romanick wrote: On 04/24/2018 07:00 PM, Timothy Arceri wrote: On 25/04/18 07:34, Ian Romanick wrote: On 04/24/2018 09:28 AM, Ian Romanick wrote: On 04/23/2018 08:23 PM, Timothy Arceri wrote: On 24/04/18 10:13, Dieter Nützel wrote: Hello Timo, what about 2 and 3, #1

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-26 Thread Ian Romanick
On 04/24/2018 07:00 PM, Timothy Arceri wrote: > > > On 25/04/18 07:34, Ian Romanick wrote: >> On 04/24/2018 09:28 AM, Ian Romanick wrote: >>> On 04/23/2018 08:23 PM, Timothy Arceri wrote: On 24/04/18 10:13, Dieter Nützel wrote: > Hello Timo, > > what about 2 and 3, #1 landed. >>>

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-24 Thread Timothy Arceri
On 25/04/18 07:34, Ian Romanick wrote: On 04/24/2018 09:28 AM, Ian Romanick wrote: On 04/23/2018 08:23 PM, Timothy Arceri wrote: On 24/04/18 10:13, Dieter Nützel wrote: Hello Timo, what about 2 and 3, #1 landed. It turns out the old radeon classic drivers do make use of the param dropped

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-24 Thread Ian Romanick
On 04/24/2018 09:28 AM, Ian Romanick wrote: > On 04/23/2018 08:23 PM, Timothy Arceri wrote: >> On 24/04/18 10:13, Dieter Nützel wrote: >>> Hello Timo, >>> >>> what about 2 and 3, #1 landed. >> >> It turns out the old radeon classic drivers do make use of the param >> dropped in patch 2 so I've deci

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-24 Thread Ian Romanick
On 04/23/2018 08:23 PM, Timothy Arceri wrote: > On 24/04/18 10:13, Dieter Nützel wrote: >> Hello Timo, >> >> what about 2 and 3, #1 landed. > > It turns out the old radeon classic drivers do make use of the param > dropped in patch 2 so I've decided to drop that patch, although the use > of that p

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-23 Thread Timothy Arceri
On 24/04/18 10:13, Dieter Nützel wrote: Hello Timo, what about 2 and 3, #1 landed. It turns out the old radeon classic drivers do make use of the param dropped in patch 2 so I've decided to drop that patch, although the use of that param might be a bug as the intel drivers changed their beha

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-23 Thread Dieter Nützel
Hello Timo, what about 2 and 3, #1 landed. Dieter Am 15.04.2018 18:16, schrieb Brian Paul: The series looks OK to me. Reviewed-by: Brian Paul On 04/13/2018 10:45 PM, Timothy Arceri wrote: The extra params we unused by the drivers that used DrawBuffers. --- src/mesa/drivers/common/driverf

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-15 Thread Brian Paul
The series looks OK to me. Reviewed-by: Brian Paul On 04/13/2018 10:45 PM, Timothy Arceri wrote: The extra params we unused by the drivers that used DrawBuffers. --- src/mesa/drivers/common/driverfuncs.c| 1 - src/mesa/drivers/dri/nouveau/nouveau_state.c | 4 ++-- src/mesa/main/buf

[Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-13 Thread Timothy Arceri
The extra params we unused by the drivers that used DrawBuffers. --- src/mesa/drivers/common/driverfuncs.c| 1 - src/mesa/drivers/dri/nouveau/nouveau_state.c | 4 ++-- src/mesa/main/buffers.c | 8 ++-- src/mesa/main/dd.h | 2 -- src/mesa/s