Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2019-01-22 Thread Marek Olšák
On Thu, Nov 29, 2018 at 11:23 AM Koenig, Christian wrote: > Hi Marek, > > you stumbled over a pretty fundamental bug in the memory management here. > Essentially we where leaking BOs when we ran into an OOM situation. Patch > to fix this is on the mailing list. > > A second problem is that

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-29 Thread Koenig, Christian
Hi Marek, you stumbled over a pretty fundamental bug in the memory management here. Essentially we where leaking BOs when we ran into an OOM situation. Patch to fix this is on the mailing list. A second problem is that eviction doesn't seem to work when GDS BOs aren't idle. In other words

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-28 Thread Marek Olšák
Hi Christian, I just pushed the commits. The best way to reproduce the out-of-memory errors is to run 2 instances of the test simultaneously: R600_DEBUG=testgdsmm glxgears & R600_DEBUG=testgdsmm glxgears & It takes about 10 seconds to finish and you'll get a lot of errors. If you run it

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-28 Thread Marek Olšák
No. I can push them after they are reviewed or acked. Marek On Wed, Nov 28, 2018 at 2:16 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Are those committed yet? They don't seem to apply cleanly on master. > > Christian. > > Am 27.11.18 um 02:56 schrieb Marek Olšák: > > From:

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-28 Thread Christian König
Are those committed yet? They don't seem to apply cleanly on master. Christian. Am 27.11.18 um 02:56 schrieb Marek Olšák: From: Marek Olšák --- .../drivers/radeonsi/si_compute_blit.c| 4 +- src/gallium/drivers/radeonsi/si_cp_dma.c | 49 ++-

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-26 Thread Marek Olšák
GDS = Global Data Share (on-chip memory) IB = indirect buffer (command buffer) Marek On Mon, Nov 26, 2018 at 9:07 PM Mike Lothian wrote: > Hi > > What's GDS and IB stand for? > > Thanks > > Mike > > On Tue, 27 Nov 2018, 01:57 Marek Olšák, wrote: > >> From: Marek Olšák >> >> --- >>

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-26 Thread Mike Lothian
Hi What's GDS and IB stand for? Thanks Mike On Tue, 27 Nov 2018, 01:57 Marek Olšák, wrote: > From: Marek Olšák > > --- > .../drivers/radeonsi/si_compute_blit.c| 4 +- > src/gallium/drivers/radeonsi/si_cp_dma.c | 49 ++- > src/gallium/drivers/radeonsi/si_pipe.h

[Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-26 Thread Marek Olšák
From: Marek Olšák --- .../drivers/radeonsi/si_compute_blit.c| 4 +- src/gallium/drivers/radeonsi/si_cp_dma.c | 49 ++- src/gallium/drivers/radeonsi/si_pipe.h| 8 +-- .../drivers/radeonsi/si_test_dma_perf.c | 3 +- 4 files changed, 33 insertions(+),