Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-12 Thread Michel Dänzer
On 12/01/17 12:09 AM, Cheng, Tony wrote: > Vblank interrupt fires as soon as the last line of active region is > scanned out. > VSync interrupt fires at the vsync. > VUpdate interrupt fires HW is ready to scan out a new frame, this include > latch on double buffer registers, starting memory

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-12 Thread Michel Dänzer
On 11/01/17 08:41 PM, Andy Furniss wrote: > > Pure luck noticing this because I haven't tested modesetting driver for > ages, but - > > These patches also break full screen vdpau playback when using that. > > Result is a screen of mostly junk with a hint of the vid - looks like > when direct

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Harry Wentland
On 2017-01-11 12:50 AM, Michel Dänzer wrote: On 10/01/17 09:07 PM, Andy Furniss wrote: Andy Furniss wrote: Though recent testing shows this is not true with DAL/DC on 3.7 - todo test DC on new drm-next branch. todo done, DC for some reason on both amd-staging-4.7 and amd-staging-drm-next is

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used as back buffer and avoids extra copying v2: use clip width/height to display a portion of the surface v3: remove redundant variables, fix wrapping, rename

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
On Wed, Jan 11, 2017 at 9:25 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: >> >> Hi Andy, >> >> Can you try this patch? This should help with the tearing. > > > Patch seems to be good - I get page flipping again so DC, modesetting > and "normal" setup all work OK. > Great.

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Andy Furniss
Nayan Deshmukh wrote: Hi Andy, Can you try this patch? This should help with the tearing. Patch seems to be good - I get page flipping again so DC, modesetting and "normal" setup all work OK. diff --git a/src/gallium/state_trackers/vdpau/output.c b/src/gallium/state_trackers/vdpau/output.c

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Cheng, Tony
To: Michel Dänzer <mic...@daenzer.net>; Andy Furniss <adf.li...@gmail.com>; Nayan Deshmukh <nayan26deshm...@gmail.com> Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org>; Cheng, Tony <tony.ch...@amd.com> Subject: Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
Hi Andy, Can you try this patch? This should help with the tearing. diff --git a/src/gallium/state_trackers/vdpau/output.c b/src/gallium/state_trackers/vdpau/output.c index 48e3133..98a8011 100644 --- a/src/gallium/state_trackers/vdpau/output.c +++ b/src/gallium/state_trackers/vdpau/output.c @@

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Andy Furniss
Michel Dänzer wrote: On 11/01/17 05:13 PM, Nayan Deshmukh wrote: On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer wrote: On 10/01/17 06:53 PM, Nayan Deshmukh wrote: On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: On 06/01/17 05:50 AM, Andy

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Michel Dänzer
On 11/01/17 05:13 PM, Nayan Deshmukh wrote: > On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer wrote: >> On 10/01/17 06:53 PM, Nayan Deshmukh wrote: >>> On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: On 06/01/17 05:50 AM, Andy Furniss wrote:

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer wrote: > On 10/01/17 06:53 PM, Nayan Deshmukh wrote: >> On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: >>> On 06/01/17 05:50 AM, Andy Furniss wrote: Christian König wrote: > Am 04.01.2017 um

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Michel Dänzer
On 10/01/17 06:53 PM, Nayan Deshmukh wrote: > On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: >> On 06/01/17 05:50 AM, Andy Furniss wrote: >>> Christian König wrote: Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: > dri3 allows us to send handle of a texture

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Michel Dänzer
On 10/01/17 09:07 PM, Andy Furniss wrote: > Andy Furniss wrote: > >> Though recent testing shows this is not true with DAL/DC on 3.7 - >> todo test DC on new drm-next branch. > > todo done, DC for some reason on both amd-staging-4.7 and > amd-staging-drm-next is "slower" = the tear region is 2

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Alex Deucher
On Tue, Jan 10, 2017 at 12:56 PM, Andy Furniss wrote: > Alex Deucher wrote: >> >> On Tue, Jan 10, 2017 at 4:50 AM, Nayan Deshmukh >> wrote: >>> >>> On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss wrote: Christian König

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Andy Furniss
Alex Deucher wrote: On Tue, Jan 10, 2017 at 4:50 AM, Nayan Deshmukh wrote: On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss wrote: Christian König wrote: Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: dri3 allows us to send handle of a texture

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Alex Deucher
On Tue, Jan 10, 2017 at 4:50 AM, Nayan Deshmukh wrote: > On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss wrote: >> Christian König wrote: >>> >>> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: dri3 allows us to send handle of a texture

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Andy Furniss
Andy Furniss wrote: Though recent testing shows this is not true with DAL/DC on 3.7 - todo test DC on new drm-next branch. todo done, DC for some reason on both amd-staging-4.7 and amd-staging-drm-next is "slower" = the tear region is 2 to 3 times larger than non DC kernel with powerplay

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Andy Furniss
Nayan Deshmukh wrote: On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss wrote: Christian König wrote: Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Nayan Deshmukh
On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: > On 06/01/17 05:50 AM, Andy Furniss wrote: >> Christian König wrote: >>> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: dri3 allows us to send handle of a texture directly to X so this patch allows a state

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Nayan Deshmukh
On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss wrote: > Christian König wrote: >> >> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: >>> >>> dri3 allows us to send handle of a texture directly to X >>> so this patch allows a state tracker to directly send its >>> texture to X to

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-06 Thread Michel Dänzer
On 06/01/17 05:50 AM, Andy Furniss wrote: > Christian König wrote: >> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: >>> dri3 allows us to send handle of a texture directly to X >>> so this patch allows a state tracker to directly send its >>> texture to X to be used as back buffer and avoids

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-05 Thread Andy Furniss
Christian König wrote: Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used as back buffer and avoids extra copying v2: use clip width/height to display a

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-05 Thread Leo Liu
On 01/05/2017 05:21 AM, Christian König wrote: Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used as back buffer and avoids extra copying v2: use clip

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-05 Thread Christian König
Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used as back buffer and avoids extra copying v2: use clip width/height to display a portion of the surface v3:

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-04 Thread Nayan Deshmukh
dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used as back buffer and avoids extra copying v2: use clip width/height to display a portion of the surface v3: remove redundant variables, fix wrapping, rename

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v2)

2016-11-04 Thread Leo Liu
On 11/04/2016 01:24 PM, Nayan Deshmukh wrote: On Fri, Nov 04, 2016 at 12:20:51PM -0400, Leo Liu wrote: Hi Nayan, With this patch, the resizing corruption is fixed, thanks for that. Still a few comments below. On 11/04/2016 03:08 AM, Nayan Deshmukh wrote: dri3 allows us to send handle of

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v2)

2016-11-04 Thread Nayan Deshmukh
On Fri, Nov 04, 2016 at 12:20:51PM -0400, Leo Liu wrote: > Hi Nayan, > > With this patch, the resizing corruption is fixed, thanks for that. > > Still a few comments below. > > > On 11/04/2016 03:08 AM, Nayan Deshmukh wrote: > > dri3 allows us to send handle of a texture directly to X > > so

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v2)

2016-11-04 Thread Leo Liu
Hi Nayan, With this patch, the resizing corruption is fixed, thanks for that. Still a few comments below. On 11/04/2016 03:08 AM, Nayan Deshmukh wrote: dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v2)

2016-11-04 Thread Nayan Deshmukh
dri3 allows us to send handle of a texture directly to X so this patch allows a state tracker to directly send its texture to X to be used as back buffer and avoids extra copying v2: use clip width/height to display a portion of the surface Suggested-by: Leo Liu Signed-off-by:

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-11-02 Thread Leo Liu
Regarding to xcb_present_pixmap client call, you might have to check xserver present/present.c on how xserver deal with it. Regards, Leo On 11/02/2016 10:55 AM, Nayan Deshmukh wrote: Hi Leo, To support clipping of the output texture I was trying to send a xcb_xfixes_region as the fifth

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-11-02 Thread Nayan Deshmukh
Hi Leo, To support clipping of the output texture I was trying to send a xcb_xfixes_region as the fifth argument (i.e valid-area) to xcb_present_pixmap but it still displays the entire surface. Am I missing something? Regards, Nayan ___ mesa-dev

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-31 Thread Andy Furniss
Michel Dänzer wrote: On 28/10/16 08:19 PM, Andy Furniss wrote: Michel Dänzer wrote: On 27/10/16 07:52 PM, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-31 Thread Michel Dänzer
On 28/10/16 08:19 PM, Andy Furniss wrote: > Michel Dänzer wrote: >> On 27/10/16 07:52 PM, Andy Furniss wrote: >>> Andy Furniss wrote: Michel Dänzer wrote: > On 26/10/16 08:07 PM, Andy Furniss wrote: >> >> The bad = Starting with DRI3 (which is default) I still get trashed >>

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-28 Thread Andy Furniss
Michel Dänzer wrote: On 27/10/16 07:52 PM, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Michel Dänzer
On 27/10/16 07:52 PM, Andy Furniss wrote: > Andy Furniss wrote: >> Michel Dänzer wrote: >>> On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 11:07 PM, Leo Liu wrote: > > > On 10/27/2016 01:20 PM, Nayan Deshmukh wrote: > > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: >> >>> On Thu, Oct 27, 2016 at 10:38:30AM

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/27/2016 01:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu > wrote: On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: On 10/24/2016 09:55

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:50 PM, Nayan Deshmukh wrote: > > > On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > >> >> >> On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: >> >>> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >>> On

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:17 PM, Leo Liu wrote: > > > On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: > >> On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: >> >>> >>> On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: >>> Suggested-by: Leo Liu

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/27/2016 12:20 PM, Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 10:38:30AM -0400, Leo Liu wrote: > > > On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: > > Suggested-by: Leo Liu > > Signed-off-by: Nayan Deshmukh > > --- > > src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ > >

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Leo Liu
On 10/24/2016 09:55 AM, Nayan Deshmukh wrote: Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ src/gallium/auxiliary/vl/vl_winsys_dri3.c | 89 +++ 2 files

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 11:52:13AM +0100, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Thu, Oct 27, 2016 at 11:52:13AM +0100, Andy Furniss wrote: > Andy Furniss wrote: > > Michel Dänzer wrote: > > > On 26/10/16 08:07 PM, Andy Furniss wrote: > > > > > > > > The bad = Starting with DRI3 (which is default) I still get trashed > > > > rendering full screen. Windowed including

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox window manager, which does not use compositing - IIRC this has

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Andy Furniss
Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox window manager, which does not use compositing - IIRC this has historically shown some

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
s/runs/null/ On Wed, Oct 26, 2016 at 01:57:12AM +0530, Nayan Deshmukh wrote: > Hi Andy, > > It seems that you have compiled mesa with DRI3 enabled but > vl_dri3_screen_create returns > runs when called in device.c and hence VDPAU fallbacks to using DRI2. > > BTW I have sent in the v1.1 for

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-27 Thread Nayan Deshmukh
On Tue, Oct 25, 2016 at 11:11:13PM +0100, Andy Furniss wrote: > Nayan Deshmukh wrote: > > Hi Andy, > > > > It seems that you have compiled mesa with DRI3 enabled but > > vl_dri3_screen_create returns > > runs when called in device.c and hence VDPAU fallbacks to using DRI2. > > > > BTW I have

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-26 Thread Michel Dänzer
On 26/10/16 08:07 PM, Andy Furniss wrote: > > The bad = Starting with DRI3 (which is default) I still get trashed > rendering full screen. Windowed including re-sizing seems OK. > > I use Fluxbox window manager, which does not use compositing - > IIRC this has historically shown some ddx DRI2/3

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-26 Thread Andy Furniss
Nayan Deshmukh wrote: On Tue, Oct 25, 2016 at 11:11:13PM +0100, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Andy, It seems that you have compiled mesa with DRI3 enabled but vl_dri3_screen_create returns runs when called in device.c and hence VDPAU fallbacks to using DRI2. BTW I have sent

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Andy Furniss
Nayan Deshmukh wrote: Hi Andy, It seems that you have compiled mesa with DRI3 enabled but vl_dri3_screen_create returns runs when called in device.c and hence VDPAU fallbacks to using DRI2. BTW I have sent in the v1.1 for patch 2 which play the video using dri2 in case of a fallback. Patch

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Nayan Deshmukh
Hi Andy, It seems that you have compiled mesa with DRI3 enabled but vl_dri3_screen_create returns runs when called in device.c and hence VDPAU fallbacks to using DRI2. BTW I have sent in the v1.1 for patch 2 which play the video using dri2 in case of a fallback. Regards, Nayan.

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Andy Furniss
Leo Liu wrote: On 10/25/2016 02:42 PM, Andy Furniss wrote: Christian König wrote: Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Leo Liu
On 10/25/2016 02:42 PM, Andy Furniss wrote: Christian König wrote: Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function without checking if

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Andy Furniss
Christian König wrote: Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function without checking if it's available or not. Keep in mind that we

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Nayan Deshmukh
On Tue, Oct 25, 2016 at 11:08:12AM -0400, Leo Liu wrote: > > > On 10/25/2016 02:01 AM, Nayan Deshmukh wrote: > > Hi Leo, > > > > On Mon, Oct 24, 2016 at 03:18:19PM -0400, Leo Liu wrote: > > > There are a couple of other issues from a brief test: > > > > > > 1. Compile warnings for

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Leo Liu
On 10/25/2016 02:01 AM, Nayan Deshmukh wrote: Hi Leo, On Mon, Oct 24, 2016 at 03:18:19PM -0400, Leo Liu wrote: There are a couple of other issues from a brief test: 1. Compile warnings for presentation.c. I will fix this in v2 with the changes that christian suggested, it might be because

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-25 Thread Nayan Deshmukh
Hi Leo, On Mon, Oct 24, 2016 at 03:18:19PM -0400, Leo Liu wrote: > There are a couple of other issues from a brief test: > > 1. Compile warnings for presentation.c. I will fix this in v2 with the changes that christian suggested, it might be because of the use of #if which would anyway be

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-24 Thread Leo Liu
There are a couple of other issues from a brief test: 1. Compile warnings for presentation.c. 2. When window resized, it's showing corruption, and sometimes corruption will stay. Regards, Leo On 10/24/2016 11:27 AM, Nayan Deshmukh wrote: On Mon, Oct 24, 2016 at 8:48 PM, Christian König

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-24 Thread Nayan Deshmukh
On Mon, Oct 24, 2016 at 8:48 PM, Christian König wrote: > Nice work, have you been able to fix all the issues you mentioned on your > last mail? > > Yes, it fixes all the known issues. But I have only tested it on my system. > Additional to that make sure that this set

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-24 Thread Christian König
Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function without checking if it's available or not. Keep in mind that we possible compile both

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-24 Thread Nayan Deshmukh
Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys.h | 4 ++ src/gallium/auxiliary/vl/vl_winsys_dri3.c | 89 +++ 2 files changed, 83 insertions(+), 10 deletions(-) diff --git