Re: [Mesa-dev] [PATCH 1/4] anv/cmd_buffer: never shrink the push constant buffer size

2018-07-02 Thread Iago Toral
On Sun, 2018-07-01 at 17:33 +0100, Lionel Landwerlin wrote: > I reread the discussion you had with Jason in order to figure out > why > this change is required. > Maybe adding a comment at the top of the function would be a good bit > of > documentation for future developers ;) Sure, I will add

Re: [Mesa-dev] [PATCH 1/4] anv/cmd_buffer: never shrink the push constant buffer size

2018-07-01 Thread Lionel Landwerlin
I reread the discussion you had with Jason in order to figure out why this change is required. Maybe adding a comment at the top of the function would be a good bit of documentation for future developers ;) Regardless this series is : Reviewed-by: Lionel Landwerlin Thanks! On 29/06/18

[Mesa-dev] [PATCH 1/4] anv/cmd_buffer: never shrink the push constant buffer size

2018-06-29 Thread Iago Toral Quiroga
If we have to re-emit push constant data, we need to re-emit all of it. --- src/intel/vulkan/anv_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index 33687920a38..3e9f000f7b8 100644 ---