Re: [Mesa-dev] [PATCH 1/4] glsl: fix visit/visit_enter overloaded virtual function warnings

2017-05-31 Thread Rob Herring
On Wed, May 31, 2017 at 5:49 PM, Ian Romanick wrote: > On 05/31/2017 06:09 AM, Emil Velikov wrote: >> On 31 May 2017 at 01:55, Ian Romanick wrote: >>> I don't understand these warnings, and I have even less understanding of >>> how "using" fixes them. For example... >>> >>> On 05/30/2017 01:47 P

Re: [Mesa-dev] [PATCH 1/4] glsl: fix visit/visit_enter overloaded virtual function warnings

2017-05-31 Thread Ian Romanick
On 05/31/2017 06:09 AM, Emil Velikov wrote: > On 31 May 2017 at 01:55, Ian Romanick wrote: >> I don't understand these warnings, and I have even less understanding of >> how "using" fixes them. For example... >> >> On 05/30/2017 01:47 PM, Rob Herring wrote: >>> clang gives warnings about overload

Re: [Mesa-dev] [PATCH 1/4] glsl: fix visit/visit_enter overloaded virtual function warnings

2017-05-31 Thread Emil Velikov
On 31 May 2017 at 01:55, Ian Romanick wrote: > I don't understand these warnings, and I have even less understanding of > how "using" fixes them. For example... > > On 05/30/2017 01:47 PM, Rob Herring wrote: >> clang gives warnings about overloaded virtual functions: >> >> src/compiler/glsl/linke

Re: [Mesa-dev] [PATCH 1/4] glsl: fix visit/visit_enter overloaded virtual function warnings

2017-05-31 Thread Samuel Pitoiset
I'm not sure if it's a good idea to hide these warnings, I think there is an underlying design issue over there. On 05/30/2017 10:47 PM, Rob Herring wrote: clang gives warnings about overloaded virtual functions: src/compiler/glsl/linker.cpp:244:30: warning: '(anonymous namespace)::array_resi

Re: [Mesa-dev] [PATCH 1/4] glsl: fix visit/visit_enter overloaded virtual function warnings

2017-05-30 Thread Ian Romanick
I don't understand these warnings, and I have even less understanding of how "using" fixes them. For example... On 05/30/2017 01:47 PM, Rob Herring wrote: > clang gives warnings about overloaded virtual functions: > > src/compiler/glsl/linker.cpp:244:30: warning: '(anonymous > namespace)::array

[Mesa-dev] [PATCH 1/4] glsl: fix visit/visit_enter overloaded virtual function warnings

2017-05-30 Thread Rob Herring
clang gives warnings about overloaded virtual functions: src/compiler/glsl/linker.cpp:244:30: warning: '(anonymous namespace)::array_resize_visitor::visit' hides overloaded virtual function [-Woverloaded-virtual] virtual ir_visitor_status visit(ir_variable *var) ^