Re: [Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

2016-02-18 Thread Ilia Mirkin
On Thu, Feb 18, 2016 at 7:07 AM, Neil Roberts wrote: > Looks good to me. Interestingly we have a test for it in Piglit which > gets run with samples=0 and it is currently passing so presumably it is > broken. Indeed. I sent a patch for this last night as well. I'll push it out along with this cha

Re: [Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

2016-02-18 Thread Neil Roberts
Looks good to me. Interestingly we have a test for it in Piglit which gets run with samples=0 and it is currently passing so presumably it is broken. Reviewed-by: Neil Roberts - Neil Ilia Mirkin writes: > From ARB_sample_shading: > > "gl_NumSamples is the total number of samples in the fr

Re: [Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

2016-02-17 Thread eocallaghan
Reviewed-by: Edward O`Callaghan I had the same issue also. On 2016-02-16 17:31, Ilia Mirkin wrote: From ARB_sample_shading: "gl_NumSamples is the total number of samples in the framebuffer, or one if rendering to a non-multisample framebuffer" So make sure to always pass in at least

[Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

2016-02-15 Thread Ilia Mirkin
From ARB_sample_shading: "gl_NumSamples is the total number of samples in the framebuffer, or one if rendering to a non-multisample framebuffer" So make sure to always pass in at least 1. Signed-off-by: Ilia Mirkin --- src/mesa/program/prog_statevars.c | 2 +- 1 file changed, 1 insert