Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-25 Thread Julien Isorce
On 19 June 2015 at 10:24, Jose Fonseca jfons...@vmware.com wrote: On 19/06/15 04:46, Ian Romanick wrote: On 06/17/2015 10:53 PM, Julien Isorce wrote: From: Jon TURNEY jon.tur...@dronecode.org.uk On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-19 Thread Jose Fonseca
On 19/06/15 04:46, Ian Romanick wrote: On 06/17/2015 10:53 PM, Julien Isorce wrote: From: Jon TURNEY jon.tur...@dronecode.org.uk On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-18 Thread Ian Romanick
On 06/17/2015 10:53 PM, Julien Isorce wrote: From: Jon TURNEY jon.tur...@dronecode.org.uk On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as for the mesa software renderer the

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-18 Thread Emil Velikov
On 18 June 2015 at 06:53, Julien Isorce julien.iso...@gmail.com wrote: From: Jon TURNEY jon.tur...@dronecode.org.uk On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as for the mesa

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-18 Thread Julien Isorce
Hi Emil, Do you mean adding the cast only if __APPLE__ is defined ? Actually when reading comment #2 we should get the build error for src/mesa/main/uniform_query.cpp too but it is not the case anymore. So with git blame I can see that the build error has been fixed by commit d96ed5c0 for the

[Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

2015-06-17 Thread Julien Isorce
From: Jon TURNEY jon.tur...@dronecode.org.uk On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as for the mesa software renderer the shader program handle is not a real pointer, but a