Re: [Mesa-dev] [PATCH 1/5] genxml: Fix parsing of address fields in groups.

2017-05-30 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 20/05/17 08:24, Kenneth Graunke wrote: For example, used to generate: const uint64_t v2_address = __gen_combine_address(data, &dw[2], values->Pointer, 0); ... const uint64_t v4_address = __gen_combine_address(dat

[Mesa-dev] [PATCH 1/5] genxml: Fix parsing of address fields in groups.

2017-05-20 Thread Kenneth Graunke
For example, used to generate: const uint64_t v2_address = __gen_combine_address(data, &dw[2], values->Pointer, 0); ... const uint64_t v4_address = __gen_combine_address(data, &dw[4], values->Pointer, 0); ... but now generates code with proper subscripts