On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro wrote:
> ---
>
> I already talked about this with Jason Ekstrand and Matt Turner
> privately, but just in case somebody else jump to the review:
>
> When using BRW_PREDICATE_NORMAL, the if will use all the channels of
> the register flag. But nir
Looking at the docs a bit, it looks like we should never have been
using predicate_normal for if's in the first place
Reviewed-by: Jason Ekstrand
On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro wrote:
> ---
>
> I already talked about this with Jason Ekstrand and Matt Turner
> privately, but
---
I already talked about this with Jason Ekstrand and Matt Turner
privately, but just in case somebody else jump to the review:
When using BRW_PREDICATE_NORMAL, the if will use all the channels of
the register flag. But nir_if only reads from one channel, so that
is not needed. Another hint sh