Re: [Mesa-dev] [PATCH 1/5] mesa: Have validate_uniform_parameters return the gl_uniform_storage pointer

2014-09-11 Thread Erik Faye-Lund
On Thu, Sep 11, 2014 at 8:35 PM, Ian Romanick wrote: > On 09/11/2014 05:09 AM, Erik Faye-Lund wrote: >> On Thu, Sep 11, 2014 at 2:00 PM, Tapani Pälli wrote: >>> On 09/11/2014 02:27 PM, Erik Faye-Lund wrote: On Sat, Aug 2, 2014 at 4:09 AM, Ian Romanick wrote: > diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH 1/5] mesa: Have validate_uniform_parameters return the gl_uniform_storage pointer

2014-09-11 Thread Ian Romanick
On 09/11/2014 05:09 AM, Erik Faye-Lund wrote: > On Thu, Sep 11, 2014 at 2:00 PM, Tapani Pälli wrote: >> On 09/11/2014 02:27 PM, Erik Faye-Lund wrote: >>> On Sat, Aug 2, 2014 at 4:09 AM, Ian Romanick wrote: diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp >

Re: [Mesa-dev] [PATCH 1/5] mesa: Have validate_uniform_parameters return the gl_uniform_storage pointer

2014-09-11 Thread Erik Faye-Lund
On Thu, Sep 11, 2014 at 2:00 PM, Tapani Pälli wrote: > On 09/11/2014 02:27 PM, Erik Faye-Lund wrote: >> On Sat, Aug 2, 2014 at 4:09 AM, Ian Romanick wrote: >>> diff --git a/src/mesa/main/uniform_query.cpp >>> b/src/mesa/main/uniform_query.cpp >>> index 609d94b..7b089fa 100644 >>> --- a/src/mesa/

Re: [Mesa-dev] [PATCH 1/5] mesa: Have validate_uniform_parameters return the gl_uniform_storage pointer

2014-09-11 Thread Tapani Pälli
On 09/11/2014 02:27 PM, Erik Faye-Lund wrote: > On Sat, Aug 2, 2014 at 4:09 AM, Ian Romanick wrote: >> diff --git a/src/mesa/main/uniform_query.cpp >> b/src/mesa/main/uniform_query.cpp >> index 609d94b..7b089fa 100644 >> --- a/src/mesa/main/uniform_query.cpp >> +++ b/src/mesa/main/uniform_query.c

Re: [Mesa-dev] [PATCH 1/5] mesa: Have validate_uniform_parameters return the gl_uniform_storage pointer

2014-09-11 Thread Erik Faye-Lund
On Thu, Sep 11, 2014 at 1:27 PM, Erik Faye-Lund wrote: > On Sat, Aug 2, 2014 at 4:09 AM, Ian Romanick wrote: >> diff --git a/src/mesa/main/uniform_query.cpp >> b/src/mesa/main/uniform_query.cpp >> index 609d94b..7b089fa 100644 >> --- a/src/mesa/main/uniform_query.cpp >> +++ b/src/mesa/main/unifo

Re: [Mesa-dev] [PATCH 1/5] mesa: Have validate_uniform_parameters return the gl_uniform_storage pointer

2014-09-11 Thread Erik Faye-Lund
On Sat, Aug 2, 2014 at 4:09 AM, Ian Romanick wrote: > diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp > index 609d94b..7b089fa 100644 > --- a/src/mesa/main/uniform_query.cpp > +++ b/src/mesa/main/uniform_query.cpp > @@ -266,30 +265,32 @@ validate_uniform_parameters(s

Re: [Mesa-dev] [PATCH 1/5] mesa: Have validate_uniform_parameters return the gl_uniform_storage pointer

2014-08-02 Thread Kenneth Graunke
On Friday, August 01, 2014 07:09:15 PM Ian Romanick wrote: > From: Ian Romanick > > This simplifies all the callers, and it enables the removal of one of > the function parameters. > > Signed-off-by: Ian Romanick Nice! Thanks for tidying up this code. This series is: Reviewed-by: Kenneth Gra

[Mesa-dev] [PATCH 1/5] mesa: Have validate_uniform_parameters return the gl_uniform_storage pointer

2014-08-01 Thread Ian Romanick
From: Ian Romanick This simplifies all the callers, and it enables the removal of one of the function parameters. Signed-off-by: Ian Romanick --- src/mesa/main/uniform_query.cpp | 61 - 1 file changed, 30 insertions(+), 31 deletions(-) diff --git a/src/