[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2016-01-05 Thread Edward O'Callaghan
Fix silly issue with MSVC case fall-though support to need a extra 'break;' Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +-

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2016-01-05 Thread eocallaghan
On 2016-01-06 10:30, Brian Paul wrote: Series looks OK to me. Reviewed-by: Brian Paul Do you need someone to commit/push for you? I do yes, thank you kindly. Edward. -Brian On 01/05/2016 03:07 AM, Edward O'Callaghan wrote: Fix silly issue with MSVC case fall-though

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2016-01-05 Thread Brian Paul
Series looks OK to me. Reviewed-by: Brian Paul Do you need someone to commit/push for you? -Brian On 01/05/2016 03:07 AM, Edward O'Callaghan wrote: Fix silly issue with MSVC case fall-though support to need a extra 'break;' Found-by: Coccinelle Signed-off-by: Edward

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-17 Thread Marek Olšák
On Thu, Dec 17, 2015 at 5:13 AM, Matt Turner wrote: > On Wed, Dec 16, 2015 at 7:41 PM, Edward O'Callaghan > wrote: >> Fix silly issue with MSVC case fall-though support to need >> a extra 'break;' >> >> Found-by: Coccinelle >> Signed-off-by:

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-16 Thread Matt Turner
On Wed, Dec 16, 2015 at 7:41 PM, Edward O'Callaghan wrote: > Fix silly issue with MSVC case fall-though support to need > a extra 'break;' > > Found-by: Coccinelle > Signed-off-by: Edward O'Callaghan > Reviewed-by: Brian Paul

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-16 Thread Michel Dänzer
On 17.12.2015 12:41, Edward O'Callaghan wrote: > Fix silly issue with MSVC case fall-though support to need > a extra 'break;' This sentence describes what changed in this version of the patch compared to the previous version, right? If so, it should be prefixed by something like "v2: ",

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-16 Thread Edward O'Callaghan
Fix silly issue with MSVC case fall-though support to need a extra 'break;' Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +-

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-14 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 2 +- src/gallium/auxiliary/nir/tgsi_to_nir.c| 2 +- src/gallium/auxiliary/util/u_surface.c

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-14 Thread Brian Paul
On 12/14/2015 09:27 AM, Edward O'Callaghan wrote: Found-by: Coccinelle Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_swizzle.c | 2 +- src/gallium/auxiliary/nir/tgsi_to_nir.c

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2015-12-14 Thread Emil Velikov
On 14 December 2015 at 18:11, Brian Paul wrote: > On 12/14/2015 09:27 AM, Edward O'Callaghan wrote: >> --- a/src/gallium/auxiliary/util/u_surface.c >> +++ b/src/gallium/auxiliary/util/u_surface.c >> @@ -600,7 +600,7 @@ is_box_inside_resource(const struct pipe_resource >> *res,