Re: [Mesa-dev] [PATCH 1/7] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit (v2)

2018-02-26 Thread Jason Ekstrand
On Mon, Feb 26, 2018 at 10:09 AM, Chema Casanova wrote: > On 26/02/18 18:20, Jason Ekstrand wrote: > > I've lost track of what's reviewed and what's not. Could you either > > just send a status list or do a resend once all the current comments are > > handled? > >

Re: [Mesa-dev] [PATCH 1/7] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit (v2)

2018-02-26 Thread Chema Casanova
On 26/02/18 18:20, Jason Ekstrand wrote: > I've lost track of what's reviewed and what's not.  Could you either > just send a status list or do a resend once all the current comments are > handled? Reviewed-by and all feedback addressed -- [1/7] anv/spirv:

Re: [Mesa-dev] [PATCH 1/7] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit (v2)

2018-02-26 Thread Jason Ekstrand
I've lost track of what's reviewed and what's not. Could you either just send a status list or do a resend once all the current comments are handled? --Jason On February 26, 2018 09:08:01 Chema Casanova wrote: On 26/02/18 16:54, Jason Ekstrand wrote: On Mon, Feb

Re: [Mesa-dev] [PATCH 1/7] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit (v2)

2018-02-26 Thread Chema Casanova
On 26/02/18 16:54, Jason Ekstrand wrote: > On Mon, Feb 26, 2018 at 6:14 AM, Jose Maria Casanova Crespo > > wrote: > > The surfaces that backup the GPU buffers have a boundary check that > considers that access to partial dwords are

Re: [Mesa-dev] [PATCH 1/7] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit (v2)

2018-02-26 Thread Chema Casanova
On 26/02/18 15:40, Ilia Mirkin wrote: > On Mon, Feb 26, 2018 at 9:14 AM, Jose Maria Casanova Crespo > wrote: >> The surfaces that backup the GPU buffers have a boundary check that >> considers that access to partial dwords are considered out-of-bounds. >> For example,

Re: [Mesa-dev] [PATCH 1/7] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit (v2)

2018-02-26 Thread Jason Ekstrand
On Mon, Feb 26, 2018 at 6:14 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > The surfaces that backup the GPU buffers have a boundary check that > considers that access to partial dwords are considered out-of-bounds. > For example, buffers with 1/3 16-bit elemnts has size 2 or 6

Re: [Mesa-dev] [PATCH 1/7] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit (v2)

2018-02-26 Thread Ilia Mirkin
On Mon, Feb 26, 2018 at 9:14 AM, Jose Maria Casanova Crespo wrote: > The surfaces that backup the GPU buffers have a boundary check that > considers that access to partial dwords are considered out-of-bounds. > For example, buffers with 1/3 16-bit elemnts has size 2 or 6

[Mesa-dev] [PATCH 1/7] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit (v2)

2018-02-26 Thread Jose Maria Casanova Crespo
The surfaces that backup the GPU buffers have a boundary check that considers that access to partial dwords are considered out-of-bounds. For example, buffers with 1/3 16-bit elemnts has size 2 or 6 and the last two bytes would always be read as 0 or its writting ignored. The introduction of